rufuscoder / Shakespeer

A Direct Connect Client for Multiple Platforms
GNU General Public License v2.0
28 stars 13 forks source link

Investigate "bugs" found by clang #45

Closed rufuscoder closed 11 years ago

rufuscoder commented 11 years ago

Original author: markus.m...@gmail.com (July 16, 2008 13:24:19)

I did a quick clang (http://clang.llvm.org/StaticAnalysis.html) run on ShakesPeer and found a few memory leaks in the Cocoa code, they have been fixed in r427 and r428.

However, there were a bunch of dead store and null dereferencing bugs found in the C code. As I am not very fluent in C, someone who is should check it out to see if they are real bugs or if clang is mistaken.

The list can be found at: http://gunnar.konstochvanligasaker.se/~markus/clang_shakespeer

Original issue: http://code.google.com/p/shakespeer/issues/detail?id=45

rufuscoder commented 11 years ago

From hwa...@gmail.com on July 16, 2008 16:18:52 I would just ignore the harmless dead stores and take a look at the null deref bugs. In many of the cases, the 'fix' could be as simple as checkıng a pointer for null before using it or before going into a branch that will use it. For example:

rufuscoder commented 11 years ago

From martin.h...@gmail.com on August 17, 2008 10:17:35 Fixed by r452.