Closed rufuscoder closed 11 years ago
From hwa...@gmail.com on May 21, 2008 10:22:46 Did this crash when the preference window was just opened? I think the bug is that we sign up for these notifications before the nib is loaded. Then if you get into shareDuplicateFoundNotification: -- it will work on an uninitialized pointer (the menu).
If you can reproduce the bug, please try this patch.
From hwa...@gmail.com on May 21, 2008 10:24:10 BTW, there are other places where we do GUI/notification things in -init instead of awakeFromNib.
I've already fixed some other places before, but it would be good to go through and fix them all.
From markus.m...@gmail.com on May 21, 2008 10:25:11 That is very probably the culprit here.
From markus.m...@gmail.com on May 21, 2008 10:37:25 I'll go through them and fix this.
From markus.m...@gmail.com on May 21, 2008 11:25:12 Work in progress. This patch should fix the crash, but I have temporarily disabled the actual code of the duplicate notification, as it needs to be rewritten.
Any new duplicate paths should be added to a local array/set, and the duplicate menu should instead be generated from scratch when it is opened. It would also be nice if the menu generation method checked if the file at the paths actually exists, and remove them from the local array/set if they don't, then regenerate the menu.
This is a likely case, since someone detecting unwanted duplicates through the menu probably deletes the duplicates right away.
From martin.h...@gmail.com on May 23, 2008 05:42:50 I don't have any details on this crash, it's from the crash reporter files.
Original author: martin.h...@gmail.com (May 21, 2008 09:40:46)
Date/Time: 2008-05-20 03:37:13.927 +0300 OS Version: 10.4.11 (Build 8S2167) Report Version: 4
Command: ShakesPeer Path: /Applications/ShakesPeer.app/Contents/MacOS/ShakesPeer Parent: WindowServer [54]
Version: ??? (0.9.7)
PID: 308 Thread: 0
Exception: EXC_BAD_ACCESS (0x0001) Codes: KERN_PROTECTION_FAILURE (0x0002) at 0x00000000
Thread 0 Crashed: 0 <<00000000>> 0xffff0897 __memcpy + 247 (cpu_capabilities.h:228) 1 com.apple.CoreFoundation 0x908292f5 CFArrayGetValues + 296 2 com.apple.Foundation 0x92806436 -[NSArray objectEnumerator] + 112 3 se.hedenfalk.shakespeer 0x0001bb42 -[SPPreferenceController shareDuplicateFoundNotification:] + 114 4 com.apple.Foundation 0x927ed237 _nsnote_callback + 230 5 com.apple.CoreFoundation 0x908563ce CFXNotificationPost + 345 6 com.apple.CoreFoundation 0x9084db49 _CFXNotificationPostNotification + 600 7 com.apple.Foundation 0x927e57c8 -[NSNotificationCenter postNotificationName:object:userInfo:] + 121 8 se.hedenfalk.shakespeer 0x0000d073 sendNotification + 259 9 se.hedenfalk.shakespeer 0x0000d4a2 spcb_share_duplicate_found + 82 10 se.hedenfalk.shakespeer 0x0003ca0f cmd_dispatch + 335 11 se.hedenfalk.shakespeer 0x00032b07 sp_dispatch_command + 55 12 se.hedenfalk.shakespeer 0x00031901 sp_in_event + 129 13 se.hedenfalk.shakespeer 0x0000ef0b sp_callback + 59 14 com.apple.CoreFoundation 0x90842f1f CFSocketDoCallback + 473 15 com.apple.CoreFoundation 0x90842c94 __CFSocketPerformV0 + 392 16 com.apple.CoreFoundation 0x9082cefa CFRunLoopRunSpecific + 1213 17 com.apple.CoreFoundation 0x9082ca36 CFRunLoopRunInMode + 61 18 com.apple.HIToolbox 0x92de7878 RunCurrentEventLoopInMode + 285 19 com.apple.HIToolbox 0x92de6f82 ReceiveNextEventCommon + 385 20 com.apple.HIToolbox 0x92de6dd9 BlockUntilNextEventMatchingListInMode + 81 21 com.apple.AppKit 0x9326d0e5 _DPSNextEvent + 572 22 com.apple.AppKit 0x9326ccd7 -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 137 23 com.apple.AppKit 0x93266a64 -[NSApplication run] + 512 24 com.apple.AppKit 0x9325a9c0 NSApplicationMain + 573 25 se.hedenfalk.shakespeer 0x00002e02 _start + 216 26 se.hedenfalk.shakespeer 0x00002d29 start + 41
Thread 1: 0 libSystem.B.dylib 0x90009cd7 mach_msg_trap + 7 1 com.apple.CoreFoundation 0x9082d21b CFRunLoopRunSpecific + 2014 2 com.apple.CoreFoundation 0x9082ca36 CFRunLoopRunInMode + 61 3 com.apple.Foundation 0x9282aa40 +[NSURLConnection(NSURLConnectionInternal) _resourceLoadLoop:] + 259 4 com.apple.Foundation 0x927f539c forkThreadForFunction + 123 5 libSystem.B.dylib 0x90024227 _pthread_body + 84
Thread 2: 0 libSystem.B.dylib 0x9001a1cc select + 12 1 libSystem.B.dylib 0x90024227 _pthread_body + 84
Thread 3: 0 libSystem.B.dylib 0x90009cd7 mach_msg_trap + 7 1 com.apple.CoreFoundation 0x9082d21b CFRunLoopRunSpecific + 2014 2 com.apple.CoreFoundation 0x9082ca36 CFRunLoopRunInMode + 61 3 com.apple.Foundation 0x92851c76 +[NSURLCache _diskCacheSyncLoop:] + 206 4 com.apple.Foundation 0x927f539c forkThreadForFunction + 123 5 libSystem.B.dylib 0x90024227 _pthread_body + 84
Thread 0 crashed with X86 Thread State (32-bit): eax: 0x00075a8c ebx: 0x908291db ecx: 0x0000000c edx: 0xfff8a580 edi: 0x00075a80 esi: 0x0e77ea8c ebp: 0xbfffeb48 esp: 0xbfffeb40 ss: 0x0000001f efl: 0x00010206 eip: 0xffff0897 cs: 0x00000017 ds: 0x0000001f es: 0x0000001f fs: 0x00000000 gs: 0x00000037
Binary Images Description: 0x1000 - 0x9afff se.hedenfalk.shakespeer ??? (0.9.7)
/Applications/ShakesPeer.app/Contents/MacOS/ShakesPeer 0xd6000 - 0xe2fff org.andymatuschak.Sparkle ??? (1.1)
/Applications/ShakesPeer.app/Contents/Frameworks/Sparkle.framework/Versions/A/Sparkle 0x8fe00000 - 0x8fe4afff dyld 46.16 /usr/lib/dyld 0x90000000 - 0x90171fff libSystem.B.dylib /usr/lib/libSystem.B.dylib 0x901c1000 - 0x901c3fff libmathCommon.A.dylib /usr/lib/system/libmathCommon.A.dylib 0x901c5000 - 0x90202fff com.apple.CoreText 1.1.3 (???)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText. framework/Versions/A/CoreText 0x90229000 - 0x902fffff ATS
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.fram ework/Versions/A/ATS 0x9031f000 - 0x90774fff com.apple.CoreGraphics 1.258.77 (???)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGrap hics.framework/Versions/A/CoreGraphics 0x9080b000 - 0x908d3fff com.apple.CoreFoundation 6.4.10 (368.33)
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x90911000 - 0x90911fff com.apple.CoreServices 10.4 (???)
/System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x90913000 - 0x90a07fff libicucore.A.dylib /usr/lib/libicucore.A.dylib 0x90a57000 - 0x90ad6fff libobjc.A.dylib /usr/lib/libobjc.A.dylib 0x90aff000 - 0x90b63fff libstdc++.6.dylib /usr/lib/libstdc++.6.dylib 0x90bd2000 - 0x90bd9fff libgcc_s.1.dylib /usr/lib/libgcc_s.1.dylib 0x90bde000 - 0x90c51fff com.apple.framework.IOKit 1.4.8 (???)
/System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x90c66000 - 0x90c78fff libauto.dylib /usr/lib/libauto.dylib 0x90c7e000 - 0x90f24fff com.apple.CoreServices.CarbonCore 682.28
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.fra mework/Versions/A/CarbonCore 0x90f67000 - 0x90fcffff com.apple.CoreServices.OSServices 4.1
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.fram ework/Versions/A/OSServices 0x91008000 - 0x91047fff com.apple.CFNetwork 129.22 (129.23)
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.fram ework/Versions/A/CFNetwork 0x9105a000 - 0x9106afff com.apple.WebServices 1.1.3 (1.1.0)
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/WebServicesCor e.framework/Versions/A/WebServicesCore 0x91075000 - 0x910f4fff com.apple.SearchKit 1.0.7
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.frame work/Versions/A/SearchKit 0x9112e000 - 0x9114cfff com.apple.Metadata 10.4.4 (121.36)
/System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.frame work/Versions/A/Metadata 0x91158000 - 0x91166fff libz.1.dylib /usr/lib/libz.1.dylib 0x91169000 - 0x91308fff com.apple.security 4.5.2 (29774)
/System/Library/Frameworks/Security.framework/Versions/A/Security 0x91406000 - 0x9140efff com.apple.DiskArbitration 2.1.2 /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x91415000 - 0x9141cfff libbsm.dylib /usr/lib/libbsm.dylib 0x91420000 - 0x91446fff com.apple.SystemConfiguration 1.8.6
/System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x91458000 - 0x914cefff com.apple.audio.CoreAudio 3.0.5 /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x9151f000 - 0x9151ffff com.apple.ApplicationServices 10.4 (???)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x91521000 - 0x9154cfff com.apple.AE 314 (313)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/AE.frame work/Versions/A/AE 0x9155f000 - 0x91633fff com.apple.ColorSync 4.4.10
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync .framework/Versions/A/ColorSync 0x9166e000 - 0x916e1fff com.apple.print.framework.PrintCore 4.6 (177.13)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore. framework/Versions/A/PrintCore 0x9170f000 - 0x917b8fff com.apple.QD 3.10.25 (???)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.frame work/Versions/A/QD 0x917de000 - 0x91829fff com.apple.HIServices 1.5.2 (???)
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices .framework/Versions/A/HIServices 0x91848000 - 0x9185efff com.apple.LangAnalysis 1.6.3
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnal ysis.framework/Versions/A/LangAnalysis 0x9186a000 - 0x91884fff com.apple.FindByContent 1.5
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/FindByCo ntent.framework/Versions/A/FindByContent 0x9188e000 - 0x918cbfff com.apple.LaunchServices 182
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LaunchSer vices.framework/Versions/A/LaunchServices 0x918df000 - 0x918ebfff com.apple.speech.synthesis.framework 3.5
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSy nthesis.framework/Versions/A/SpeechSynthesis 0x918f2000 - 0x91932fff com.apple.ImageIO.framework 1.5.6
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/ImageIO 0x91945000 - 0x919f7fff libcrypto.0.9.7.dylib /usr/lib/libcrypto.0.9.7.dylib 0x91a3d000 - 0x91a53fff libcups.2.dylib /usr/lib/libcups.2.dylib 0x91a58000 - 0x91a76fff libJPEG.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libJPEG.dylib 0x91a7b000 - 0x91adafff libJP2.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libJP2.dylib 0x91aec000 - 0x91af0fff libGIF.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libGIF.dylib 0x91af2000 - 0x91b7afff libRaw.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libRaw.dylib 0x91b7e000 - 0x91bbbfff libTIFF.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libTIFF.dylib 0x91bc1000 - 0x91bdbfff libPng.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libPng.dylib 0x91be0000 - 0x91be2fff libRadiance.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.f ramework/Versions/A/Resources/libRadiance.dylib 0x91be4000 - 0x91cc2fff libxml2.2.dylib /usr/lib/libxml2.2.dylib 0x91cdf000 - 0x91cdffff com.apple.Accelerate 1.3.1 (Accelerate 1.3.1)
/System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x91ce1000 - 0x91d6ffff com.apple.vImage 2.5
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework /Versions/A/vImage 0x91d76000 - 0x91d76fff com.apple.Accelerate.vecLib 3.3.1 (vecLib 3.3.1)
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/ Versions/A/vecLib 0x91d78000 - 0x91dd1fff libvMisc.dylib
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/ Versions/A/libvMisc.dylib 0x91dda000 - 0x91dfefff libvDSP.dylib
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/ Versions/A/libvDSP.dylib 0x91e06000 - 0x9220ffff libBLAS.dylib
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/ Versions/A/libBLAS.dylib 0x92249000 - 0x925fdfff libLAPACK.dylib
/System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/ Versions/A/libLAPACK.dylib 0x9262a000 - 0x92717fff libiconv.2.dylib /usr/lib/libiconv.2.dylib 0x92719000 - 0x92797fff com.apple.DesktopServices 1.3.7 /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopService sPriv 0x927d8000 - 0x92a08fff com.apple.Foundation 6.4.10 (567.37)
/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x92b22000 - 0x92b39fff libGL.dylib
/System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x92b44000 - 0x92b9cfff libGLU.dylib
/System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x92bb0000 - 0x92bb0fff com.apple.Carbon 10.4 (???)
/System/Library/Frameworks/Carbon.framework/Versions/A/Carbon 0x92bb2000 - 0x92bc2fff com.apple.ImageCapture 3.0.4
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/ImageCapture.framew ork/Versions/A/ImageCapture 0x92bd1000 - 0x92bd9fff com.apple.speech.recognition.framework 3.6
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.fra mework/Versions/A/SpeechRecognition 0x92bdf000 - 0x92be4fff com.apple.securityhi 2.0.1 (24742)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SecurityHI.framework /Versions/A/SecurityHI 0x92bea000 - 0x92c7bfff com.apple.ink.framework 101.2.1 (71)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Ink.framework/Versio ns/A/Ink 0x92c8f000 - 0x92c92fff com.apple.help 1.0.3 (32.1)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Help.framework/Versi ons/A/Help 0x92c95000 - 0x92cb3fff com.apple.openscripting 1.2.5 (???)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/OpenScripting.framew ork/Versions/A/OpenScripting 0x92cc5000 - 0x92ccbfff com.apple.print.framework.Print 5.1 (192.3)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/Print.framework/Versi ons/A/Print 0x92cd1000 - 0x92d34fff com.apple.htmlrendering 66.1 (1.1.3)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HTMLRendering.frame work/Versions/A/HTMLRendering 0x92d58000 - 0x92d99fff com.apple.NavigationServices 3.4.4 (3.4.3)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/NavigationServices.fra mework/Versions/A/NavigationServices 0x92dc0000 - 0x92dcdfff com.apple.audio.SoundManager 3.9.1
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framew ork/Versions/A/CarbonSound 0x92dd4000 - 0x92dd9fff com.apple.CommonPanels 1.2.3 (73)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CommonPanels.frame work/Versions/A/CommonPanels 0x92dde000 - 0x930d3fff com.apple.HIToolbox 1.4.10 (???)
/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework /Versions/A/HIToolbox 0x931d9000 - 0x931e4fff com.apple.opengl 1.4.16 /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0x93254000 - 0x93254fff com.apple.Cocoa 6.4 (???)
/System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x93256000 - 0x9390cfff com.apple.AppKit 6.4.10 (824.45)
/System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x93c8d000 - 0x93d08fff com.apple.CoreData 91 (92.1)
/System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x93d41000 - 0x93dfafff com.apple.audio.toolbox.AudioToolbox 1.4.7
/System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x93e3d000 - 0x93e3dfff com.apple.audio.units.AudioUnit 1.4.2
/System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x93e3f000 - 0x94000fff com.apple.QuartzCore 1.4.12
/System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x94046000 - 0x94087fff libsqlite3.0.dylib /usr/lib/libsqlite3.0.dylib 0x9408f000 - 0x940c9fff libGLImage.dylib
/System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x940ce000 - 0x940e4fff com.apple.CoreVideo 1.4.2
/System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x94278000 - 0x94287fff libCGATS.A.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGrap hics.framework/Versions/A/Resources/libCGATS.A.dylib 0x9428e000 - 0x94299fff libCSync.A.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGrap hics.framework/Versions/A/Resources/libCSync.A.dylib 0x942e5000 - 0x942fffff libRIP.A.dylib
/System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGrap hics.framework/Versions/A/Resources/libRIP.A.dylib 0x94d4d000 - 0x94dfffff com.apple.WebKit 4525.18
/System/Library/Frameworks/WebKit.framework/Versions/A/WebKit 0x94e6a000 - 0x94f31fff com.apple.JavaScriptCore 4525.17
/System/Library/Frameworks/JavaScriptCore.framework/Versions/A/JavaScriptCore 0x94f6d000 - 0x9555ffff com.apple.WebCore 4525.18.1
/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks/WebCore.framework/ Versions/A/WebCore 0x98042000 - 0x9804ffff libbz2.1.0.dylib /usr/lib/libbz2.1.0.dylib 0xc0000000 - 0xc0008fff com.growl.growlframework 1.1.2
/Applications/ShakesPeer.app/Contents/Frameworks/Growl.framework/Versions/A/Growl
Original issue: http://code.google.com/p/shakespeer/issues/detail?id=21