UPnP / NAT-PMP port detection support

rufuscoder / Shakespeer

A Direct Connect Client for Multiple Platforms

GNU General Public License v2.0

28 stars 13 forks source link

UPnP / NAT-PMP port detection support #76

Closed rufuscoder closed 11 years ago

rufuscoder commented 11 years ago

Original author: hwa...@gmail.com (May 18, 2008 18:33:20)

It would be nice if shakespeer had UPnP/NAT-PMP support for easy port setup.

http://miniupnp.free.fr/libnatpmp.html seems like a good candidate since NAT-PMP seems to be well-support by Apple routers, but I guess UPnP support wouldn't hurt...

Original issue: http://code.google.com/p/shakespeer/issues/detail?id=5

rufuscoder commented 11 years ago

From zintis.p...@e-mail.lv on May 18, 2008 19:40:29 I guess there is an exmple at torrent project transmission. http://www.transmissionbt.com/

rufuscoder commented 11 years ago

From izak...@gmail.com on July 24, 2008 18:53:14 There is also a project that wraps libnatpmp in Cocoa, located at http://code.google.com/p/tcmportmapper/.

rufuscoder commented 11 years ago

From markus.m...@gmail.com on July 31, 2008 21:44:24 Hey, that really seems like a smooth framework, we should probably use it. Seems trivial to implement, Håkan you up for it?

rufuscoder commented 11 years ago

From hwa...@gmail.com on August 11, 2008 10:44:03 Working on this

rufuscoder commented 11 years ago

From hwa...@gmail.com on August 12, 2008 10:45:30 I've checked in support for this, that uses the framework from comment 2. I've tested it a lot, and it works pretty well for me on 10.5 using a d-link router.

Please bang on it, and let me know if there are any problems.

There are some remaining things/bugs to tackle:

Should the default pref be on or off? I think on would be good for new users, but off for existing users (because you don't want to mess up people's already-working settings) but I'm not sure how to do that. It might be worth it to see what default settings Transmission and other apps use.
On shutdown of the app (applicationWillTerminate), we call SPNetworkingPortController's shutdown method to remove any current port mappings. For some reason this seems to not work for me. I'm not sure if it's a framework bug, or if it's our bug. Maybe the code needs to wait for the framework to send a notification that it's done removing the port, before we can continue to quit.

rufuscoder commented 11 years ago

From hwa...@gmail.com on August 12, 2008 10:55:37 Two more things:

We should attribute the framework and the miniupnp guys somewhere.
According to this (http://code.google.com/p/tcmportmapper/wiki/BasicUsage) we can remove a plist file (because we don't use the router name feature) and save 434K from the filesize. This is simplest to do in the make rule just after unzipping the framework.

rufuscoder commented 11 years ago

From hwa...@gmail.com on August 17, 2008 11:04:19 Has anyone else tested this yet and either noticed other issues, or just got it working OK?

rufuscoder commented 11 years ago

From hwa...@gmail.com on August 17, 2008 12:11:56 I finally got the shutdown to work cleanly (at least for me with my dlink test router). I've also fixed all other above, except for the default pref.

If someone knows how to turn it on for new users, and not touch existing users' prefs, file a bug and attach a patch. :-)

Committed in r457

rufuscoder commented 11 years ago

From markus.m...@gmail.com on August 17, 2008 15:56:08 I am not sure there are any problems with using UPnP on ports that are also forwarded on the router. We should test this, and if it seems to work fine, just activate UPnP by default.