rufusnguyen / Yelp

CoderSchool - Week 2
0 stars 0 forks source link

[Week 2] Project 3 - Review my app #1

Open rufusnguyen opened 9 years ago

rufusnguyen commented 9 years ago

Hello teacher,

I think I'm suffering with autolayout. It takes me 2-3 days to master it that's why I don't have enough time to finish all required requirements. But I tried my best, so please help me to review it!

/cc @chug2k

chug2k commented 9 years ago

Hmm, I can't find a Podfile so I can't compile this project. Can you please commit the Podfile?

Looks like you did all right. No AutoLayout errors, although in this case you have an unnecessary constraint (you already set height to 20, no need to do >= 20): image

Also you have some duplicate constraints here: image

Try to be careful with AutoLayout. I realize it is hard. :stuck_out_tongue_winking_eye:

The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints. It was hard! You did fine with AutoLayout, congratulations.

I'm not sure you finished the searchBar implementation...

    func searchBar(searchBar: UISearchBar, textDidChange searchText: String) {
        println(searchText)
    }

Please put more effort into the final project!