rufuspollock-okfn / bubbletree

Radial Bubble Tree Visualization
http://okfnlabs.org/bubbletree
152 stars 69 forks source link

why not bower? #37

Closed dev-johnny-gh closed 8 years ago

pwalsh commented 8 years ago

Hi @duxiaofeng-github we can do that, yes. We just did not do it as we don't use bower.

mbrk commented 8 years ago

needed this too, so forked and added: https://github.com/mbrk/bubbletree

bower install bubbletree-bowerized

pwalsh commented 8 years ago

@mbrk great! Instead of hard forking and publishing your own, it would be great if you would do a PR on the canonical repository instead (i.e.: this one), so we can publish to both npm and bower going forward.

Is there any reason why you are not doing this?

mbrk commented 8 years ago

Nope, just wasn't sure if this was welcome. Therefore i used a specific name. Will do a PR.

mbrk commented 8 years ago

https://github.com/okfn/bubbletree/pull/43

pwalsh commented 8 years ago

Thanks @mbrk it is very very welcome.

mbrk commented 8 years ago

please adjust the readme (in the end it says: "in this fork..."), and publish in bower with the correct endpoint. $ bower register <my-package-name> <git-endpoint>

pwalsh commented 8 years ago

@mbrk done, thank you.

mbrk commented 8 years ago

great!