search

rufuspollock-okfn / dataexplorer

View, visualize, clean and process data in the browser.
http://explorer.okfnlabs.org
148 stars 47 forks source link

Data package serialisation is broken #113

Closed djw closed 11 years ago

djw commented 11 years ago

Broken by 06aa9ff3bbbf6eb90e74622d943b929f76951d36 but my fault. :-)

There was a subtlety i wasn't aware of when I wrote the code to migrate data to be persisted in gists — the dataset metadata objects can be regenerated from from the underlying datasets. I was altering the metadata directly, where I should've been altering the canonical version on the dataset itself.

djw commented 11 years ago

The way to fix this is to move logic to initial save time.

djw commented 11 years ago

Also, combine the logic for the two saveToGist functions. Have a include_data option instead.