Make data editable through data grid

[landonreed]

Add ability to edit data (from * data source) in Data Explorer grid view and publish back to original data source.

prose/prose#653

[rufuspollock]

All this needs is some simple tweaks to the Recline SlickGrid view - see https://github.com/okfn/recline/issues/384

[rufuspollock]

OK, this is even easier than anticipated as recline already has most of this working and just needs to be enabled. I'll be updating the recline issue and this issue as appropriate.

Next steps for github csv editing would be just to have a route like /#github/{github-path} - we in fact had exactly something like this working in an early version of data explorer and moved it out so adding it back should be pretty easy

[landonreed]

Excellent! Any grunt work I can help with?

[rufuspollock]

@landonreed what about looking at #155 - it looks like we'll get issue fixed upstream https://github.com/okfn/recline/issues/384 soon and then we can integrate here ...

[rufuspollock]

@landonreed editability of the grid has landed in upstream recline so we just need to integrate here now :-) If you wanted to have a stab at this check out the Recline demo code here: https://github.com/okfn/recline/blob/master/demos/multiview/app.js#L77

[landonreed]

@rgrp that's great!

Can't guarantee when/if I'll be able to get to this in the near future. But I'll let you know when I finally sit down with recline for a closer look...

[aliounedia]

@rgrp HI Ruffus I have deployed the dataexplorer for test in http://dataexplorertest.herokuapp.com/ but when clicking to sign using github , I 'am redirected to http://localhost/src/dataexplorer/?code=78084e4db0bae2630f95 which don't work , Have i Missed something ?

--Ad

[landonreed]

@aliounedia you probably need to set up your own instance of gatekeeper. You'll need to create a github app (with the localhost url as the homepage/callback url) as well. Once you do this, change the settings for your gatekeeper instance here: https://github.com/okfn/dataexplorer/blob/2eead6b3b73f68b5aba508b31fffc562386a603a/src/boot.js#L4-L5

[aliounedia]

@landonreed I almost got crazy :) Thank very much . I think we should update the readme to be more understandable

[landonreed]

haha, you're right. That's probably worth documenting in the readme.

[rufuspollock]

@aliounedia @landonreed sorry this is poorly documented - generally people haven't deployed new instances (other than a local one on their machine to test)

@aliounedia you should be able to test fine on your local machine if you set up local instance to show up at http://localhost/src/dataexplorer/ (I could fix this to be somewhat nicer and be http://dataexplorer/ or something ...)

@aliounedia I also note if you need something public to demo it is worth looking at http://pagekite.net/ which allows you to basically tunnel your localhost to a public site in a secure way :-)

Anyway:

• I'm adding some docs on this right now.
• @aliounedia could you open a PR with what you have because I can always review and it would be great to get this in :-)

[rufuspollock]

@aliounedia I've added some documentation - see #158 - and I've also upgraded to latest recline lib for you.

[rufuspollock]

@aliounedia generally looks good but one issue: when you add a new row you end up with undefined rather than just empty string or null set as value. See http://explorer.okfnlabs.org/#rgrp/5403f60ea4e8c02261b1/view/grid for example

[rufuspollock]

w00t! it is all working - no doubt improvements we can make (we can pull in more slickgrid options e.g. reordering rows) but this is good to go.

@landonreed all we now need to do is wire this up to github csvs and we can do #155

[landonreed]

Nice! I've been learning here and there and think I'm in a better position to help out with this github connection.

[rufuspollock]

@landonreed just noting here that this is all working now including editing github csvs :-)

[landonreed]

Nice! Sorry I couldn't contribute too much, but I've been following the progress and it looks (and works) great!

---

Landon Reed | http://landonreed.net @eltiar https://twitter.com/eltiar

On Sun, Jun 8, 2014 at 6:14 PM, Rufus Pollock notifications@github.com wrote:

@landonreed https://github.com/landonreed just noting here that this is all working now including editing github csvs :-)

— Reply to this email directly or view it on GitHub https://github.com/okfn/dataexplorer/issues/154#issuecomment-45450232.

[rufuspollock]

@landonreed no problem - even just using it and finding bugs and suggesting improvements would be very welcome.