search

rufuspollock-okfn / dataexplorer

View, visualize, clean and process data in the browser.
http://explorer.okfnlabs.org
148 stars 47 forks source link

[#154] make data editable through grid #159

Closed aliounedia closed 10 years ago

rufuspollock commented 10 years ago

@aliounedia this only has changes to tests - are no changes needed to main code? I imagined we'd need to turn editability "on" (?)

aliounedia commented 10 years ago

@rgrp , Hi ruffus maybe I should change something into main code , but I don't know what ? , Have you any ideas .For this moment I juste integrate the last version of reclinejs and some tests, be sure that change on grid are passed to projects.datasets . If you have any suggestion for things to do
http://dataexplorertest.herokuapp.com/#aliounedia/9f3be9163e80ef54cb72/view/grid --Ad

rufuspollock commented 10 years ago

@aliounedia I'm just checking here re the pull request - if you look at the changes the only changes are to test files - are you sure you haven't missed out some files from the PR?

Also looking at your example, my immediate question is: should we limit editing of the data to the project owner? (or like the scripting - allow anyone to do it - even if they can't save ...)?

rufuspollock commented 10 years ago

@aliounedia ping :-) - I would love to get this feature in so let me know if i can help or should just dive in :-)

aliounedia commented 10 years ago

@rgrp Ruffus , Let me just check to be sure that change grid are stored to gist /juste one or two days .DataExplorer is a great code and I don't be the guy who break something :)

Ruffus say [ Also looking at your example, my immediate question is: should we limit editing of the data to the project owner? (or like the scripting - allow anyone to do it - even if they can't save ...)? ]

For this point you are missing something :) In my fork I have have enabled the grid options http://dataexplorertest.herokuapp.com/#aliounedia/9f3be9163e80ef54cb72/view/grid

And in the original fork (your) not http://dataexplorertest.herokuapp.com/#rgrp/e3e0b0f18dfe151f9f7e/view/grid

see the two gists files :)

rufuspollock commented 10 years ago

@aliounedia but how have you enabled the grid options - have you done in the underlying gist?

Ahhhh! I realize you have - the whole point here would be to enable this by default for the grid instances - I guess this means, at the moment, a bit of a hack in the model object to that when we load we add those gridOptions - i guess this is one of those places that serializing state seems a bit odd. I'll have a quick stab now and you can then update!

rufuspollock commented 10 years ago

@aliounedia I've pushed some work here - but it does not seem to be saving (and clicking on delete does not work right) - do you want to pull and take a look :-)

aliounedia commented 10 years ago

@rgrp ok let me check

rufuspollock commented 10 years ago

@aliounedia any thoughts here - i can do some more hacking :-)

aliounedia commented 10 years ago

@rgrp Hi ruffus , i had not any time to work on it this week end , so I will commit today .