rufuspollock-okfn / dataexplorer

View, visualize, clean and process data in the browser.
http://explorer.okfnlabs.org
148 stars 47 forks source link

Github auth broken / cross-site request to transformer-datahub-gatekeeper.herokuapp.com #162

Closed hannesgassert closed 10 years ago

hannesgassert commented 10 years ago

When I try to authenticate against Github on http://explorer.okfnlabs.org/?code=..., Google Chrome gets stuck on the "Completing Login" screen. In the console I see the following error:

XMLHttpRequest cannot load http://transformer-datahub-gatekeeper.herokuapp.com//authenticate/742d0f7c73fb9ece36ce. 
No 'Access-Control-Allow-Origin' header is present on the requested resource. 
Origin 'http://explorer.okfnlabs.org' is therefore not allowed access. 
rufuspollock commented 10 years ago

@hannesgassert can you give any more details here (e.g. browser, browser version). I can login and logout fine atm :-/

aliounedia commented 10 years ago

@hannesgassert , me too , I can login and log out fine on chrome!

hannesgassert commented 10 years ago

Behavior above can be reproduced on Google Chrome, Version 33.0.1750.152, on a Mac.

Firefox 27.0.1 on the same machine logs in fine, but remains on /#start after closing the auth popup instead of redirecting to /#dashboard.

hannesgassert commented 10 years ago

The server sends out headers that look fine, seems to be a problem with this particular Chrome version. Chrome 35.0.1892.0 does not have the header issue. Still, I'm not redirected to the dashboard when the popup closes, so visually I have no indication that the login actually worked.

aliounedia commented 10 years ago

Yeah , this is a basic bug that we should fix , maybe right now :), i can open issue for that if you want ,but if you are logged , check menu at the left top , you will see more items like dashbord , New project and logout item .

hannesgassert commented 10 years ago

Yeah, got that. Closing this issue now, seems fine for everybody else. Feel free to open a new one for the UI/redirection issue!