rufuspollock-okfn / dataexplorer

View, visualize, clean and process data in the browser.
http://explorer.okfnlabs.org
148 stars 47 forks source link

Error signing into explorer.okfnlabs.org with Github #171

Closed edrex closed 9 years ago

edrex commented 9 years ago

It's not possible to sign in with Github currently on http://explorer.okfnlabs.org/

In the auth popup:

Failed to load resource: the server responded with a status of 404 (Not Found)

http://transformer-datahub-gatekeeper.herokuapp.com//authenticate/aaaaaaaaaaaaaaaa

(Chrome 38 OSX 10.9)

http://transformer-datahub-gatekeeper.herokuapp.com/authenticate/aaaaaaaaaaaaaaaa works.

It seems like some recent commit included a trailing slash in a base URL somewhere, or a leading slash in the path. Recent commits relating to Gist editing seem a likely culprit.

rufuspollock commented 9 years ago

This is really odd - since this was working a few months ago and no changes have been made to boot.js have been made since then that would cause this afaict. Anyway, I've spotted the issue (trailing slash on gatekeeper_url) and this should be fix now.

Thank you very much for reporting this and please let us know if you encounter any further issues.

rufuspollock commented 9 years ago

Note: gh-pages was not rebuilding. Turned out a) we were using git:// for submodules (github has changed support this recently and must be https) b) exclude in jekyll build to get rid of recline docs (which cause problems) no longer working. After patching both of these it rebuilds and login is working hurrah!

(This rebuild issue may also explain why this has only shown up recently if, in fact, site has not been rebuilding properly).

edrex commented 9 years ago

Thanks for the quick response @rgrp!