search

rug-compling / Alpino

Alpino parser and related tools for Dutch
GNU Lesser General Public License v2.1
22 stars 2 forks source link

Replace use of boost::shared_ptr by std::shared_ptr #4

Closed danieldk closed 4 years ago

danieldk commented 4 years ago

C++ has had a shared_ptr class since C++11, which is supported by all modern compilers.

gertjanvannoord commented 4 years ago

this change leads to a errors in compilation of python/indexedcorpus.so

gertjanvannoord commented 4 years ago

building 'indexedcorpus' extension creating build creating build/temp.linux-x86_64-2.7 x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I../ -I/usr/include -I/usr/include/python2.7 -c indexedcorpus.cpp -o build/temp.linux-x86_64-2.7/indexedcorpus.o cc1plus: warning: command line option ‘-Wstrict-prototypes’ is valid for C/ObjC but not for C++ In file included from ../IndexedCorpus/ActCorpusReader.hh:27:0, from indexedcorpus.cpp:9: ../IndexedCorpus/IndexedCorpusReader.hh:30:14: error: ‘shared_ptr’ in namespace ‘std’ does not name a template type typedef std::shared_ptr IndexItemPtr; ^ ../IndexedCorpus/IndexedCorpusReader.hh:32:31: error: ‘IndexItemPtr’ was not declared in this scope typedef std::map<std::string, IndexItemPtr> IndexMap; ^ ../IndexedCorpus/IndexedCorpusReader.hh:32:43: error: template argument 2 is invalid typedef std::map<std::string, IndexItemPtr> IndexMap;

etc