CorpusWriter.write() overwrites when it shouldn't

rug-compling / alpinocorpus

Library for handling Alpino corpora

GNU Lesser General Public License v2.1

8 stars 1 forks source link

Closed pebbe closed 11 years ago

pebbe commented 12 years ago

CorpusWriter.write(CorpusReader const &corpus, ...) overwrites existing entries, even is corpus was opened with overwrite=False.

pebbe commented 12 years ago

And if corpus is of type CompactCorpusWriter, the overwrite flag is ignored completely.

danieldk commented 11 years ago

CompactCorpusWriter doesn't have in-place updates (which would be difficult) anyway, so the flag doesn't apply there.

I'll look at the DbCorpusWriter case.

Edit: misread.