rugarciap / Turbo-Boost-Switcher

Turbo Boost disabler / enable app for Mac OS X
GNU General Public License v2.0
1.49k stars 149 forks source link

Show fan speed on 2018 MacBook 13" #59

Closed rgaufman closed 6 years ago

rgaufman commented 6 years ago

Presently the latest version does not show the fan speed on the new 2018 MacBooks, but TurboBoost can be successfully disabled:

screen shot 2018-07-15 at 16 16 27
rugarciap commented 6 years ago

Wow, that was fast! :) considering the first units were received yesterday on many Apple Stores!

In any case, thanks for your feedback.

Fan speed is displayed using Apple SMC Api and with generic names for fans, cpu ids, etc, so it should work...:| . In any case, will stay tuned just in case they've changed something. If you are able to send some logs will be cool too. You can try other apps that also uses SMC Api to check and post here the results, like smcFanControl app..., that'd help ;).

P.D: Later this year for holidays I hope to grab one of those and test for myself :).

rgaufman commented 6 years ago

Ah, yes, it seems to show some weird numbers with SMCFanControl:

screen shot 2018-07-16 at 08 08 13

I'm happy to share logs, but not sure which ones?

rugarciap commented 6 years ago

Thanks! no worries, knowing that smcFanControl doesn't display fan speed either is enough...

Stay tuned for future updates on this ;).

freddedotme commented 6 years ago

It seems like the fan number only would show if they were actually running. “N/A” in my case means that the fans must be idle since when I ran something heavier it all of a sudden showed a RPM number. You can ignore my issue (#60).

rugarciap commented 6 years ago

Hi again!

Could you please try with this tool and post here the results? Is this one: https://github.com/theopolis/smc-fuzzer

smc.zip

Just unzip and from command line type: ./smc -f and post here the results. If possible, a dump would be great too ./smc -l > dump.txt

Thanks!

dzaiats commented 6 years ago

Hi there! MacBook Pro 2018, max configuration.

Please, find attached dump.txt dunp.txt

The dump was taken on the low performance.

rugarciap commented 6 years ago

Great, thanks! Could you please also execute ./smc -f and post here the results!?

dzaiats commented 6 years ago

Sure! Here it is dump.txt

dzaiats commented 6 years ago

Probably I need to run something heavy and take a dump?

dzaiats commented 6 years ago

dump-f-heavy.txt dump-l-heavy.txt

I have just executed the same commands during the building of heavy Android project

rugarciap commented 6 years ago

Thanks again!

Well, as I though, now all SMC info is being encrypted by new Apple T2 chip, and for some reason (still unknown) the info is not being displayed properly. Look at the output:

Total fans in system: 2

Fan #0: Actual speed : 11502417 Key[F0Ac] Minimum speed: 465 Maximum speed: 224849 Safe speed : 0 Target speed : -261295 Mode : auto

Fan #1: Actual speed : -11329391 Key[F1Ac] Minimum speed: -367 Maximum speed: -496943 Safe speed : 0 Target speed : 262353 Mode : auto

As you can see, the speeds are just wrong! Same happens with other apps using SMC to read fan speeds, like smcFanControl.

Will investigate with the dump until I can grab a new Macbook 2018 for myself..., until then any help is appreciated!

Thanks!

rugarciap commented 6 years ago

By the way, as you can see on smc.h and SystemCommands.m, both fans (F0Ac and F1Ac) are the same that are being readed by the app:

define SMC_KEY_FAN0_RPM_CUR "F0Ac"

define SMC_KEY_FAN1_RPM_CUR "F1Ac"

rugarciap commented 6 years ago

Removed comment due to support question not related with the issue. There is plenty of info around about running the app the first time (Translocation & Kext authorization). Please, take a look to the issues history, blog, etc. Thanks.

Poopi commented 6 years ago

Was about to buy Pro version when I discovered the problem with Fan readout.

Fan fields types from SMC has been changed on MBP2018. See: bash-3.2$ ./smc -l | grep F0 F0Ac [flt ] (bytes 9b 3a 29 45) F0Dc [flt ] (bytes 45 08 90 3e) F0Fb [ui8 ] 1 (bytes 01) F0Fc [ui16] 4 (bytes 00 04) F0Md [ui8 ] 0 (bytes 00) F0Mn [flt ] (bytes 00 00 07 45) F0Mx [flt ] (bytes 00 38 b9 45) F0Sf [ui16] 0 (bytes 00 00) F0St [ui8 ] 5 (bytes 05) F0Tg [flt ] (bytes 00 30 29 45)

Attached patch solves the issue....

TBS_MBP2018.txt

Also created a pull request...

rugarciap commented 6 years ago

Great! thanks for your feedback :). Unfortunately, I can't test that myself yet because my MBP 2018 will arrive in 2 weeks (it's not a default config one)....

All seems fine and pretty obvious (it was there all the time, lol! "flt" 👍 ) will release an update as soon as I add a couple of additional fixes and probably some additional translations too.

In the meantime, if anyone else tries this, it's very welcome to post the feedback here! :)

Thanks.

rugarciap commented 6 years ago

Other projects are updating just the same :)

In example:

https://github.com/Chris911/iStats/blob/master/ext/osx_stats/smc.c

rugarciap commented 6 years ago

Just received my 2018 MBP!! :), Hope to release an update with this fix and a couple more in few days :).

rugarciap commented 6 years ago

Just released the 2.7.1 update with some additional fixes ;). Thanks to all for your feedback