rughh / on_ruby

:gem: :diamonds: Whitelabel Site for Ruby Communities
http://www.onruby.eu
229 stars 94 forks source link

Location might be off for huge buildings #211

Closed PragTob closed 8 years ago

PragTob commented 8 years ago

We have a little problem with the location for our current meetup

The address is right, the building is big and so the position of the pin is way off. It goes to 38a, not 38. Incidentally, that is also a past venue (some cache or something maybe? Seems unlikely though)

In the picture below, the pin should be at Wooga not adjust :)

selection_007

Any idea how I could fix this (now through input - already tried updating it but didn't work). Don't have time right now but my idea to fix would be:

See if we can feed the company name to geocoder. At least in google maps looking for the address yields the result as shown in the screenshot, prepending it with "Wooga" leads to the desired result

Not really a bug as technically it works, the above solution might help. Otherwise, it could be a solution to optionally manually enter lat/long

Thanks and still :heart: on_ruby

phoet commented 8 years ago

it might be as simple as adding the name to the full address. i won't be able to look into this any time soon as i'm on parental leave for the next 2 month.

phoet commented 8 years ago

unfortunately, the geocoder has the same result when the name is added:

irb(main):032:0> Geocoder.coordinates("Saarbrücker Straße 38, 10405 Berlin")
=> [52.5283101, 13.4154047]
irb(main):033:0> Geocoder.coordinates("Wooga, Saarbrücker Straße 38, 10405 Berlin")
=> [52.5283101, 13.4154047]
PragTob commented 8 years ago

thanks for looking at it and sorry for me not looking at it.

Sad that it won't work :| Only solution that comes to my mind then is manually entering it which of course is also more work :|

phoet commented 8 years ago

putting the name second seems to work

irb(main):038:0> Geocoder.coordinates("Saarbrücker Straße 38, Wooga, 10405 Berlin")
=> [52.53419359999999, 13.4230065]
phoet commented 8 years ago

oh no, that's actually far off :D reverting it