rugk / awesome-emoji-picker

Add-on/WebExtension that provides a modern emoji picker that you can use to find and copy/insert emoji into the active web page.
https://addons.mozilla.org/firefox/addon/awesome-emoji-picker/?src=external-github-top
Other
102 stars 10 forks source link

Apple/Google/Twitter/Facebook styles don't display in Thunderbird #121

Closed mozomoid closed 2 years ago

mozomoid commented 2 years ago

Hi there!

I just added this extension to my Thunderbird client. In Options > Appearence, when setting "Emoji style" other than "native", it displays nothing when loaded in TB compose window (see attached screenshot).

Awesome Emoji Picker v0.9 Thunderbird 91.2.1 (32 bits) Windows 10 Pro x64 21H1

emoji

tdulcet commented 2 years ago

Thanks for the bug report! I can confirm the issue.

@rugk - It looks like there is a separate scripts/downloadEmojiImages.sh script that I needed to run to download these images before publishing the add-on on ATN. 🙈 Maybe we should automatically run that from the scripts/make.sh script, as I did not catch that I needed to run both of those scripts. Anyway, I am happy to run the script and release a new version on ATN.

rugk commented 2 years ago

Oh yes, you do not need to do that. The reason are just size/potential licensing issues, so I don't want to bundle the files all in this repo here.

Feel free to add it there, so the script gets run automatically, yes.

tdulcet commented 2 years ago

Oh yes, you do not need to do that. The reason are just size/potential licensing issues, so I don't want to bundle the files all in this repo here.

OK, I ran the script and released a new v0.9.1 on ATN. This issue can now be closed.

@mozomoid - You should automatically get the update within 24 hours or you can force it from the Add-ons manager. Thanks again for the bug report!

mozomoid commented 2 years ago

Wow that was quick! I got automatic update to v0.9.1 and everything is fine now. This add-on is, well... awsome ^^ Thanks to both of you