rugk / awesome-emoji-picker

Add-on/WebExtension that provides a modern emoji picker that you can use to find and copy/insert emoji into the active web page.
https://addons.mozilla.org/firefox/addon/awesome-emoji-picker/?src=external-github-top
Other
103 stars 10 forks source link

Messenger blocked when using Facebook's instantaneous messages #37

Closed Prometheos2 closed 4 years ago

Prometheos2 commented 5 years ago

Trying to insert an emoji in the instantaneous messages results in the blockage of the Messenger in the current page.

It only does that bug when no character are into the dialog box beforehand.

I assume it's on Fb's side, like an non-handled error or an anti-bot/flood/spam measure; so it might be hard to fix that. I'm not sure we can access the message field to determine whether or not the field is empty through the add-on.

rugk commented 5 years ago

Thanks for the report. Yes, it's likely specific to that site. Maybe they don't even have a real input field when there is no character entered yet.

Anyway, there is indeed hardly anything I can do. But good that it's tracked. Just as the other site issues.

Prometheos2 commented 5 years ago

Would it be possible to detect when the cursor is in the Messenger "box" and block the emoji insertion?

Or, if that is the problem, detecting a loss of focus from the Messenger box when the add-on dialog box opens?

rugk commented 5 years ago

Anything is possible, but this sounds like a very specific cumbersome workaround (which does not even actually fix the problem of insertion, just prevent bad side effects). Though it may be worth it for such a big site.

I am not completly oppoosed to it, but it has to be well-thought. E.g. make it such generic that one can later add similar/other workarounds for other sites. That said, I'd appreciate concrete development ideas or even pull requests on that feature. 😃

Also, BTW, do you have a screenshot on how that "blockage" looks like?

Prometheos2 commented 5 years ago

"That said, I'd appreciate concrete development ideas or even pull requests on that feature. 😃" Oh no 😥

Well, it's complicated, since it's more about not being able to reopen some dialog rather than something more "screenshot-able"

I will send you the JS console logs instead

Is "browser-polyfill.min.js" your thing?

Prometheos2 commented 5 years ago

console-export-2019-9-19_18-40-39.txt

rugk commented 5 years ago

Hmm, okay, I don't see any error related to this bug/add-on or so.

Is "browser-polyfill.min.js" your thing?

No, that has to be a different add-on. You can look up the add-on ID in about:debugging.

Prometheos2 commented 5 years ago

That's weird, then. It would truly be on Fb's side?


No, that has to be a different add-on.

I've checked, and yes, it's another extension. It probably attempts to access the (now-crashed) message box.

QA is hard ^^

Prometheos2 commented 5 years ago

Addendum: It also concerns the Messenger page itself, as it blocks the text area until refreshment (cf. screenshot & JS console extract), but the emoji is inserted and can be seen on refresh.


Screenshot

image

JS Console extracts

ErrorUtils caught an error: "React reported an error from NotFoundError: Node was not found". Subsequent errors won't be logged; see https://fburl.com/debugjs. 8gEnQK1P6Dl.js:51:246 Source map error: Error: NetworkError when attempting to fetch resource. Resource URL: moz-extension://660ce86a-a063-4dab-8aea-184db93e38bb/browser-polyfill.min.js Source Map URL: browser-polyfill.min.js.map

extended JS console extract.txt

Prometheos2 commented 4 years ago

With the new version of the website, the issue seems to be solved.

However, like in #38, inserting two (or more) emojis results in very awkward events. That's hard to pinpoint what it gives.

Edit: it somehow broke again with the awkward insertion. But the core problem seems to be solved; trying to insert an emoji without focusing on the Messenger's tab leads to a copy of the smiley, not an insert.

rugk commented 4 years ago

Okay, so if this problem is fixed, that's good, please open a new issue.

If the other issue is really the same as https://github.com/rugk/awesome-emoji-picker/issues/38, we could expand https://github.com/rugk/awesome-emoji-picker/issues/38 to also track the Messenger problem, but this one here seems fixed so I'm closing this.