rugk / awesome-emoji-picker

Add-on/WebExtension that provides a modern emoji picker that you can use to find and copy/insert emoji into the active web page.
https://addons.mozilla.org/firefox/addon/awesome-emoji-picker/?src=external-github-top
Other
102 stars 10 forks source link

Mixed emojis #97

Closed AXeL-dev closed 2 years ago

AXeL-dev commented 4 years ago

Bug description

I noticed that some emojis were displayed over each others (check the screenshot below), but i'm not sure if this is really a bug or maybe something else.

image

System

Operating system and version: Linux (Ubuntu 18.04) Browser and version: Firefox (Latest) Add-on version: Latest

rugk commented 4 years ago

Which emoji style do you use? "native" I guess?

If so these are emojis that are combined using a ZWJ. If the font/emoji set you use does not support these emojis, it will display them as two emojis.

This then results in an overflow.

So the underlying error is totally technical here and cannot really be solved by us… :thinking: Or do you have an idea how?

Also, this likely also happens in our upstream library, does not it? If so, it's possibly also an issue for them in general…

Workaround: (for now) use/choose a different emoji set in the settings (or, e.g. upgrade Firefox and/or Ubuntu – maybe the latest version has a better emoji support)

rugk commented 4 years ago

oh BTW, I can reproduce it with Firefox 77 and Fedora 32, so an upgrade won't help. (It looks a little better here for me with a slightly bigger emoji size though)

emojiOverflow

An emoji affected is e.g. the person cook 🧑‍🍳, i.e. the gender-neutral version of 👨‍🍳 & 👩‍🍳. See https://emojipedia.org/cook/. It has been introduced in Emoji 12.1, so apparently Firefox does not support that version yet. I guess that is likely already known/reported, but I could not find a new Firefox bugzilla bug, so I've opened https://bugzilla.mozilla.org/show_bug.cgi?id=1644346.

You can also see that issue in the release notes of v2.0: https://github.com/rugk/awesome-emoji-picker/releases/tag/v2.0

AXeL-dev commented 4 years ago

Okay, thank you, i have a better understanding now about the source of the issue :+1:

Edit: i don't know if i should close this issue, but it might be good to let it opened as long as the issue still exist on Firefox Linux version.

rugk commented 4 years ago

Well… given the Firefox issue has been fixed in record time, I'll certainly leave this open until that is released or so (in Firefox 79).

Also we might think what we could do to detect/workaround these errors in the future? (as it is likely prune to reoccur) Maybe detect the emojis based on their width or so and hide them? Though that may be a too big maintenance and potential problem burden for such an edge case workaround. It could e.g. lead to false-positives on Windows with that: https://github.com/missive/emoji-mart/issues/310.

So yeah, for now marking it as a blocked upstream (Firefox) issue.

rugk commented 4 years ago

Ups, accidentally closed.

Fixed in Firefox 78 now even, so that when Firefox 78 arrives, I'll close this one.

rugk commented 2 years ago

Arrived long ago… :upside_down_face: