Remove local lock system/Require borg v1.1.0

rugk / borg-cron-helper

Helper shell scripts for BorgBackup to automate backups and make your life easier… 😉

MIT License

81 stars 14 forks source link

Remove local lock system/Require borg v1.1.0 #33

Open rugk opened 7 years ago

rugk commented 7 years ago

Depreciating old software is never easy, but in v2.0 we may:

still have a 1.0.0 branch, which receives security fixes (and maybe critical bugfixes) if needed
continue development for borg >= v1.1.0 only, i.e. we can remove the whole local lock system as borg 1.1.0 has fixed the originating issue

Avi0n commented 6 years ago

First off, thank you for making these scripts, they are amazing. Is there any update on this issue? I would like to be able to use the latest version of borg with your scripts.

rugk commented 6 years ago

Thanks for the praise. (which you posted 2 times) You can use the latest version of borg with my scripts. This issue is about depreciating old borg versions for this script.

Avi0n commented 6 years ago

I see. I'm having a problem where after every backup, it remains locked so it cannot complete the next backup. But if you say it works with current versions of borg then I probably have something configured incorrectly. Thanks.

rugk commented 6 years ago

If you encounter an issue, which you think is a bug in the script, feel free to open an issue. Usually, when backups end successfully and the script is not interrupted all lock files are supposed to be deleted.

But BTW, if you use the new borg version, you can also just disable the local lock system, as the new version is supposed to have fixed the problem with stale locks.

rugk commented 5 years ago

See here for what versions still use borg v1.0: https://repology.org/metapackage/borgbackup/versions

So as far as I see, we cannot deprecate it yet as Debian and others still use it. :cry:

rugk commented 5 years ago

BTW @avion540 if you set $RUN_PID_DIR to an empty string it does disable the lock system.