rugk / crops-parser

🌱🍎🍆 A shell script to parse the data by the Food and Agriculture Organization of the United Nations on crops/fruits.
Other
15 stars 4 forks source link

Fallback #42

Closed westnordost closed 7 years ago

westnordost commented 7 years ago

So for a few countries, there are very few, sometimes only one, entries in the mostPlantedCrops_2014%2B2013_OSMonly.yml which is a problem because then for i.e. Vietnam, you'd have only one choice - bananas. Obviously the FAO data is not complete, so there must be some kind of fallback.

Do you have ideas?

Solutions come to my mind:

rugk commented 7 years ago

Maybe just have an entry "default" (which I had previously), which is used to fill-up the list to 15 items when there are too few ones… It should just reflect the global "top-15" list. Well… maybe there are countries where not many different fruits are planted. :smile:

climate zones, have a dictionary

Thing is, we do not have this.

rugk commented 7 years ago

Note that we also have some countries (e.g. Western Sahara) where we have no data at all… I mean you are also unlikely to find an "orchard" in the Western Sahara, but you should at least have the possibility to mark it as "nonexistent" or so… So I think showing some default fruits there would not hurt.

Another idea would be to use the data from countries "near" the current country for filling the list. That could get more useful/accurate data than just using the default. However, I think, that's quite difficult to implement.

rugk commented 7 years ago

I think this is not the only quest where data is missing for some countries, so how do you handle this case in the other quests? Use some default?

westnordost commented 7 years ago

For sports, there is indeed a default order and the country specific info is just used to reorder the list (not to exclude allothers)

On July 27, 2017 1:12:47 PM GMT+02:00, rugk notifications@github.com wrote:

I think this is not the only quest where data is missing for some countries, so how do you handle this case in the other quests? Use some default?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/rugk/crops-parser/issues/42#issuecomment-318332776

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

westnordost commented 7 years ago

(By the way I did a little research out of interest and found that at least jackfruit and pineapples are produced in Vietnam.)

rugk commented 7 years ago

AFAIK jackfruit are not included in our (OSM tags) list currently.

westnordost commented 7 years ago

I'll go with

have the "show more" button show all defined fruits - this is... not so good because most are irrelevant for any given location

Not too nice, but we put too much work into this quest already.