Closed rugk closed 7 years ago
Okay, so as noted in #39, you can replace the nuts with the specific nuts.
Your change of pepper to chilli and pipers to peppers is confusing. Should not produce=pepper also belong to pepper_plants and so on?
Oh right, probably. This must be a mistake.
Soo, merge this?
Soo, merge this?
Please see other comments, first.
Which one?
https://github.com/rugk/crops-parser/pull/45#discussion_r131002048 and https://github.com/rugk/crops-parser/pull/45#discussion_r131002746
I said "everything else looks fine" in my review with these two comments.
I actually found out: piper and petter are synonyms. So what to use?
Note: The scientific name Piper and the common name "pepper"
Pepper
LGTM, @westnordost?
And BTW: It sucks somehow to have to change things in a PR, which is not mine. So next time, I'd prefer a real PR. Just saying… It's easier that way. :smiley:
All good, thanks!
and improve it generally, created by @westnordost.
Fixes https://github.com/rugk/crops-parser/issues/36 As a demonstration I also generated one YAML file with it.