search

rugk / crops-parser

🌱🍎🍆 A shell script to parse the data by the Food and Agriculture Organization of the United Nations on crops/fruits.
Other
15 stars 4 forks source link

Add produce to osmcrops.csv #45

Closed rugk closed 7 years ago

rugk commented 7 years ago

and improve it generally, created by @westnordost.

Fixes https://github.com/rugk/crops-parser/issues/36 As a demonstration I also generated one YAML file with it.

westnordost commented 7 years ago

Okay, so as noted in #39, you can replace the nuts with the specific nuts.

rugk commented 7 years ago

Your change of pepper to chilli and pipers to peppers is confusing. Should not produce=pepper also belong to pepper_plants and so on?

westnordost commented 7 years ago

Oh right, probably. This must be a mistake.

westnordost commented 7 years ago

Soo, merge this?

rugk commented 7 years ago

Soo, merge this?

Please see other comments, first.

westnordost commented 7 years ago

Which one?

rugk commented 7 years ago

https://github.com/rugk/crops-parser/pull/45#discussion_r131002048 and https://github.com/rugk/crops-parser/pull/45#discussion_r131002746

I said "everything else looks fine" in my review with these two comments.

rugk commented 7 years ago

I actually found out: piper and petter are synonyms. So what to use?

Note: The scientific name Piper and the common name "pepper"

westnordost commented 7 years ago

Pepper

rugk commented 7 years ago

LGTM, @westnordost?

And BTW: It sucks somehow to have to change things in a PR, which is not mine. So next time, I'd prefer a real PR. Just saying… It's easier that way. :smiley:

westnordost commented 7 years ago

All good, thanks!