search

rugk / offline-qr-code

📱 Browser add-on allowing you to quickly generate a QR code offline with the URL of the open tab or other text!
https://addons.mozilla.org/firefox/addon/offline-qr-code-generator/?utm_source=github.com&utm_medium=github&utm_content=github-url-description&campaign=github-url-description
Other
423 stars 129 forks source link

QR code scanner/reader #52

Open rugk opened 6 years ago

rugk commented 6 years ago

There are also many JS libraries for just scanning a QR code:

So maybe we could integrate that, too.

rugk commented 6 years ago

Features may be:

rugk commented 6 years ago

This add-on shows what I mean: https://addons.mozilla.org/de/firefox/addon/qrcode-generator-and-reader/

rugk commented 5 years ago

Possibly a good lib: https://github.com/zxing-js/library

jamescallumyoung commented 5 years ago

@rugk Saw this after your link from #213

right-click on image (or canvas, or so) -> decode QR code I like this. Not too invasive and it's a good contextual option.

... scan from webcam This not so much; I like that this is a small extension. More permissions and camara use would scare me off.

Just my 2 cents.

rugk commented 5 years ago

More permissions and camara use would scare me off.

This would definitively only be requested at runtime when you use it. (It would use WebRTC, which has this built-in.) An add-on actually does not have more permissions than a usual web page in this regards…

Harinath333 commented 3 weeks ago

Any one working on this issue???

Harinath333 commented 3 weeks ago

If no one I want to work on this using html5-qrcode

rugk commented 2 weeks ago

You can do so, that sounds great, but keep in mind this may be a big task and require some back- and forth.

First of, you would have to:

Harinath333 commented 2 weeks ago

You can do so, that sounds great, but keep in mind this may be a big task and require some back- and forth.

First of, you would have to:

  • think of some GUI, like I tried in https://github.com/rugk/offline-qr-code/issues/52#issuecomment-385027154 to get started
  • decide which lib to use, which you apparently did, but I'd like to know the reasons of why you'd choose this lib. (Does not mean it's wrong, I just like to have it documented or so); also note this issue is old, maybe there are more modern/better libs out there we did not thought about yet – did you have a look for these? My initial listing in the first comment was just meant as a starter for further research, it does not mean one of these libs needs to be used.

The thing is html5 is very good to use as it is supported by so many browsers and I also think there are more better libs let me go through that!!

Harinath333 commented 2 weeks ago

Hey we just need a qr code scanner from the webcam right! then we can make it by Html5 with qr code lib. Which will let us use the webcam from the user to scan a qr. Let me know if this is what we need

rugk commented 2 weeks ago

Technically it should work with the webcam and yes likely use a lib (which uses the WebRTC technologies for accessing a webcam, I guess)…

But as indicated, one first has to think about a UI and find a good lib. Maybe also look for (preferably open-source) websites that already implement such a feature (and look what they use).

Harinath333 commented 2 weeks ago

Technically it should work with the webcam and yes likely use a lib (which uses the WebRTC technologies for accessing a webcam, I guess)…

But as indicated, one first has to think about a UI and find a good lib. Maybe also look for (preferably open-source) websites that already implement such a feature (and look what they use).

Yeah I will make one which will have a decent UI and It can use WebRTC