search

rugk / offline-qr-code

📱 Browser add-on allowing you to quickly generate a QR code offline with the URL of the open tab or other text!
https://addons.mozilla.org/firefox/addon/offline-qr-code-generator/?utm_source=github.com&utm_medium=github&utm_content=github-url-description&campaign=github-url-description
Other
423 stars 129 forks source link

Accessbility analysis #82

Open rugk opened 6 years ago

rugk commented 6 years ago

One may have a deep look on whether stuff for accessibility can be improved. Considering that we use Photon colors and other standard stuff, which has been tested for accessibility already, I hope it should be quite okay.

To do so, you may have a look at the accessibility inspector of Firefox 61 or add-ons such as axe devtools.

I had a quick look at the settings and they seem to be okay: accessibilityqrcode

But because of (WebExtension) limitations in my Firefox 61 instance I could not get it to actually get it to analyze the popup though. And even the options page needs a check with axe e.g.

Also generally it may be better to run the tool outside of the browser: https://github.com/dequelabs/axe-core https://www.axe-core.org/

renatavmaraj commented 5 years ago

Hey! I am interested in doing this ticket!

rugk commented 5 years ago

Okay so, great. 😃 Please notice this is mostly a ticket for investigation, with work mostly in docs etc., and does not have to result in a PR.

As such, please (also) explain what you tested and how. And what you noticed, of course.

In the end, you may also have a look on how to fix potentially discovered issues. This could then be a PR. 😃

rugk commented 5 years ago

BTW https://ffoodd.github.io/a11y.css/errors.html may be useful.

rugk commented 5 years ago

@renatavmaraj If you need any pointers/help or have questions, feel free to ask.

rugk commented 5 years ago

Also good to read/have a look is https://a11yfirst.netlify.com/…

@renatavmaraj Are you still interested in it? If not, that's no problem, just add a notice, so I know what the current status of this issue is.

Rish-P commented 1 year ago

Can I work on this? I will need a few days to go over this and come up with something solid... that sound good?

rugk commented 1 year ago

@Rish-P Sure and thanks a lot!