Closed tdulcet closed 2 years ago
Some minor code-style comments, because that code is really hard to understand. It's likely because it is just a complex piece of code, but we can do better to use understandable variable names etc. 🙂
Thanks. I made your requested changes in https://github.com/rugk/unicodify/pull/37/commits/9d9b4035b13c4ccdc3263e8931e3e1f3e1c592cb. I know am bad at naming stuff, so please feel free anytime to suggest better names for things. 😉
beforeinput
event instead of thekeydown
andkeyup
events for autocorrection (see https://github.com/rugk/unicodify/issues/4#issuecomment-831841205).@rugk – I think this could be merged sometime after 2021-11-2 when Firefox/Thunderbird 78 will no longer be supported (see https://github.com/rugk/unicodify/issues/4#issuecomment-806543762). I would also need to make a companion PR for the Awesome Emoji Picker.