rugk / unicodify

✍️ A browser add-on (Firefox, Chrome, Thunderbird) that allows you to autocorrect common text sequences and convert text characters to a look like a special font.
https://addons.mozilla.org/firefox/addon/unicodify-text-transformer/?utm_source=github.com&utm_medium=git&utm_content=repo-about-description&utm_campaign=github
Other
11 stars 2 forks source link

Updated content script to use the `beforeinput` event #37

Closed tdulcet closed 2 years ago

tdulcet commented 3 years ago

@rugk – I think this could be merged sometime after 2021-11-2 when Firefox/Thunderbird 78 will no longer be supported (see https://github.com/rugk/unicodify/issues/4#issuecomment-806543762). I would also need to make a companion PR for the Awesome Emoji Picker.

tdulcet commented 2 years ago

Some minor code-style comments, because that code is really hard to understand. It's likely because it is just a complex piece of code, but we can do better to use understandable variable names etc. 🙂

Thanks. I made your requested changes in https://github.com/rugk/unicodify/pull/37/commits/9d9b4035b13c4ccdc3263e8931e3e1f3e1c592cb. I know am bad at naming stuff, so please feel free anytime to suggest better names for things. 😉