search

rugk / unicodify

✍️ A browser add-on (Firefox, Chrome, Thunderbird) that allows you to autocorrect common text sequences and convert text characters to a look like a special font.
https://addons.mozilla.org/firefox/addon/unicodify-text-transformer/?utm_source=github.com&utm_medium=git&utm_content=repo-about-description&utm_campaign=github
Other
11 stars 2 forks source link

Added screenshots #45

Closed tdulcet closed 3 years ago

tdulcet commented 3 years ago

Fixes #25 (screenshots only).

~Four of the Thunderbird screenshots will need to be added in a follow up PR because of https://github.com/rugk/unicodify/issues/25#issuecomment-843165128.~

The issue in https://github.com/rugk/unicodify/pull/21#pullrequestreview-646710403 is showing in some of the screenshots of the options page. I also had to modify my local copy of the extension to workaround https://github.com/TinyWebEx/AutomaticSettings/issues/11.

I was unsure of the expected format and use of the amoScreenshots.csv file, as your example in https://github.com/rugk/unicodify/issues/25#issuecomment-840626954 is an invalid CSV file, as it is using semicolons instead of commas. The name implies that it is only for AMO, although I listed all the screenshots in it.

Please let me know if you would like me to redo any of the screenshots.

rugk commented 3 years ago

is an invalid CSV file, as it is using semicolons instead of commas. The name implies that it is only for AMO, although I listed all the screenshots in it.

Well… semicolons are also a common separator in CSVs, but yeah, it does not matter since it is never automaticaly parsed. YOu actually need to manually copy it into the AMO description. :upside_down_face:

Anyway, thanks a lot and I’ll have a look/review that soon (please ping me/request a review if I should forget it).

tdulcet commented 3 years ago
  • as for optionsPageChrome.png is there any way to make it show the full page somehow?

Sure, see https://github.com/TinyWebEx/AutomaticSettings/issues/12#issuecomment-812993836. Your AutomaticSettings library would likely need to add some CSS to specify a width for the options page and possibility a height. This can also be an issue with popups in Chrome. See here for the CSS I used for my Colab Autorun and Connect add-on. I can of course add some CSS to my development copy of this add-on, although I figured we wanted the screenshots to show what it would actually look like for users.

  • As for the options, did you really choose the default options? IIRC live preview is not enabled by default, but in your screenshots it is. Or am I wrong?

Oops, looks like I forgot to reset the settings. I will retake those two screenshots.

  • Uhm funny how in Chrome/ium some squared letters are red. Do you think this warrants a new issue here? After all, it's confusing at least… (but maybe also hard to work around…)

Yeah, see https://github.com/rugk/awesome-emoji-picker/pull/93#issuecomment-710780555. Several of the letters for a couple of the Unicode fonts (see here and here) are also emojis and Chrome decided to render them as such. I do not think there is much we can do about it.

  • As for the first sentence I would have ended it with “them… how awesome!” or so instead of “them… great” as "the term “great” is already used in the sentence before. However, it’s okay, so you don’t need to recreate the screenshots just for that, only if you mind/anyway change them, you could include it! 😃

OK. I tried to select that existing “great”, but the context menu would cover almost all the text, so I just added the new “great” at the end for consistency, so all the screenshots of the text transformation feature would still use the word “great”. I obviously could not select any of the existing words in the second sentence, as they were all already transformed. Adding “how awesome!” instead is a good idea, so I will do that if I need to redo those screenshots…

tdulcet commented 3 years ago

Four of the Thunderbird screenshots will need to be added in a follow up PR because of #25 (comment).

I found a workaround for this, so I could at least take the screenshots.

rugk commented 3 years ago

Sure, do what you think is a good idea.

tdulcet commented 3 years ago

I think this PR is the last piece needed for us to release v0.5, since #4 is obviously not going to get fixed for a while. #36 and #43 included some important bug fixes we should publish/release as soon as possible.

However, one thing I noticed when taking the screenshots of the options page is that the RandomTips are still not working: image We probably should reopen #23. There are also a couple other issues listed in the third paragraph at the top of the PR that we probably should fix first…

rugk commented 3 years ago

There are also a couple other issues listed in the third paragraph at the top of the PR that we probably should fix first…

Sure, would you mind to create issues for them? Feel free to assign me if it is related to the RandomTips lib, so I’ll fix it then.