search

rugk / unicodify

✍️ A browser add-on (Firefox, Chrome, Thunderbird) that allows you to autocorrect common text sequences and convert text characters to a look like a special font.
https://addons.mozilla.org/firefox/addon/unicodify-text-transformer/?utm_source=github.com&utm_medium=git&utm_content=repo-about-description&utm_campaign=github
Other
11 stars 2 forks source link

Add Thunderbird download button and badges to README #59

Closed tdulcet closed 2 years ago

tdulcet commented 3 years ago

Add Thunderbird download button and badges to README: https://addons.thunderbird.net/en-US/thunderbird/addon/unicodify-text-transformer/ Note that TB does not currently track the number of downloads for add-ons, just the number of users. (see https://github.com/thundernest/addons-server/issues/80).

We also should consider creating a separate ATN description files for Thunderbird instead of reusing the existing AMO description files. I had to manually make several tweaks and remove irreverent information that does not apply to Thunderbird. In addition, most of the Unicode fonts and emojis are not supported on ATN, so I also had to manually remove those as well.

@rugk - I am guessing you may also want to update your AddonTemplate repository.

To do:

rugk commented 3 years ago

Oh sorry totally missed that and created https://github.com/rugk/unicodify/issues/59, yes you're right of course.Feel free to adjust that here.

We also should consider creating a separate ATN description files for Thunderbird instead of reusing the existing AMO description files. I had to manually make several tweaks and remove irreverent information that does not apply to Thunderbird.

Yes, you're right. Just make a PR with the new file.

In addition, most of the Unicode fonts and emojis are not supported on ATN, so I also had to manually remove those as well.

Hmm is not this a system/OS/browser level thing. AMO also does not render emojis in any way, they just let it render by the browser/OS. You might need to try different browsers or so (try https://www.browserstack.com/) to be sure here…

@rugk - I am guessing you may also want to update your AddonTemplate repository.

Let's first merge this here, it's not clear whether any other add-on will be compatible with Thunderbird in the future.

tdulcet commented 3 years ago

The Firefox download badge can nowadays be used/get from https://extensionworkshop.com/documentation/publish/promoting-your-extension/, I don't know where the Thunderbird badge might come from/be hosted on. Maybe @tdulcet you know more. 🙂

I am not sure… The Thunderbird developer documentation is here: https://developer.thunderbird.net/add-ons/about-add-ons, but I do not see anything related to a download button.

Yes, you're right. Just make a PR with the new file.

OK, will do.

Hmm is not this a system/OS/browser level thing. AMO also does not render emojis in any way, they just let it render by the browser/OS.

Oh, the ATN UI does not let me add most of the Unicode fonts or emojis. If I try, I just get a spinning timer forever. I tried using both the actual emojis (e.g. 😊) and the HTML entities (e.g. 😊). You are of course welcome to try yourself and maybe you will have better luck…

rugk commented 3 years ago

Oh, the ATN UI does not let me add most of the Unicode fonts or emojis. If I try, I just get a spinning timer forever.

Rather sounds as a bug at ATN's side…

rugk commented 3 years ago

Okay, asked for that button on https://discourse.mozilla.org/t/get-add-on-download-badge-button-image/84631?u=rugkx

Oh, the ATN UI does not let me add most of the Unicode fonts or emojis. If I try, I just get a spinning timer forever. Rather sounds as a bug at ATN's side…

As for that, do you want to report a bug @tdulcet?

tdulcet commented 3 years ago

As for that, do you want to report a bug @tdulcet?

OK, I created https://github.com/thundernest/addons-server/issues/170. I thought the Awesome Emoij Picker was a better example of the problem, so I used that for the issue.

tdulcet commented 3 years ago

Okay, asked for that button on https://discourse.mozilla.org/t/get-add-on-download-badge-button-image/84631?u=rugkx

If we do not get a response, we could also ask on the Thunderbird Topicbox: https://thunderbird.topicbox.com/groups/addons or create an issue here: https://github.com/thundernest/developer-docs/issues

rugk commented 3 years ago

As far as I see, it is safe to say "we did not got a response" by now… :sweat_smile:

So yeah, thanks for finding more support "forums"! Cross-posted it there, everywhere:

tdulcet commented 3 years ago

@rugk - It looks like we got a button: https://github.com/thundernest/addon-developer-support/blob/master/images/get-the-addon.svg

rugk commented 3 years ago

Ah thanks, forgot that. Created a PR in https://github.com/rugk/unicodify/pull/67. Opened https://github.com/badges/shields/issues/6994 for the badge request, but IMHO we can then close this issue if the PR is merged, because these badges are not that important.

The download button is more important here. :slightly_smiling_face: