rugk / unicodify

✍️ A browser add-on (Firefox, Chrome, Thunderbird) that allows you to autocorrect common text sequences and convert text characters to a look like a special font.
https://addons.mozilla.org/firefox/addon/unicodify-text-transformer/?utm_source=github.com&utm_medium=git&utm_content=repo-about-description&utm_campaign=github
Other
11 stars 2 forks source link

Disable autocorrect feature by default #72

Closed tdulcet closed 1 year ago

tdulcet commented 2 years ago

I believe this should finally allow us release v1.0. The Unicode autocorrection feature could then be enabled in a future release, such as v2.0.

rugk commented 2 years ago

Localized: image

rugk commented 2 years ago

So needed some CSS adjustments: https://github.com/TinyWebEx/CommonCss/pull/2

looks good now with a proper warning message: image

rugk commented 2 years ago

I also simply removed the confirm message for now. I mean, if one really skips the big yellow warning then so be it. It's not that bad. It does not kill the computer or have other non-reversible effects after all. They can just revert the setting and are fine. Also, it may be useful if you do not use one of the sites affected.

Also it was not really a great UI to have that default Firefox dialog somewhere in here, and worse, if you showed that popup multiple times, it tried to show a "do not disturb" checkbox, but the checkbox is not there… :sweat_smile: :sweat_smile:

image

rugk commented 2 years ago

requesting review from @tdulcet (cannot do via GitHub as you've opened this PR :sweat_smile: )

rugk commented 1 year ago

Ha, it looks like you found a Firefox bug. I am able to reproduce it as well.

BTW, if you want to report that bug, feel free… :upside_down_face: