search

rugk / unicodify

✍️ A browser add-on (Firefox, Chrome, Thunderbird) that allows you to autocorrect common text sequences and convert text characters to a look like a special font.
https://addons.mozilla.org/firefox/addon/unicodify-text-transformer/?utm_source=github.com&utm_medium=git&utm_content=repo-about-description&utm_campaign=github
Other
11 stars 2 forks source link

Cannot re-enable auto correction in version 0.5.1 #77

Closed amourchaleur closed 2 years ago

amourchaleur commented 2 years ago

Bug description

After the update to the latest version 0.5.1, not able to re-enable unicode autocorrection.

Steps to reproduce

When I tried clicking on the checkbox, it just doesn't checked at all. Auto correction also does not turn on.

Actual behavior

No reaction to checkbox after clicking on it.

Operating system and version: Browser and version: Thunderbird 91.11.0 (64-bit) Add-on version: 0.5.1

tdulcet commented 2 years ago

Thanks for the bug report! I did not catch this until after publishing the v0.5.1 update (the checkbox works fine in Firefox), but it is actually a Thunderbird regression, so I filed bug 1780977. If they do not fix that soon, I will release another update with a workaround (see https://github.com/rugk/unicodify/pull/72/commits/a8b95bbea3b6030dd620d290e070900eff9ca67c). Sorry for the inconvenience. See bug 1777183 for why the autocorrect feature was disabled by default in this update (another regression in Thunderbird 102).

tdulcet commented 2 years ago

I just published v0.5.2 on ATN which works around bug 1780977 to allow the autocorrection feature to be reenabled. This also fixes a regression from #37 to allow users to undo the smart quote autocorrections.

@amourchaleur - You should automatically get the update within 24 hours or you can force it from the Add-ons manager.

rugk commented 2 years ago

@tdulcet If you publish such versions, BTW, it would be great if you could at least also tag the corresponding commit you've used please. The tags here are heavily outdated and still show v0.1.

tdulcet commented 2 years ago

As I mentioned above, this was fixed by https://github.com/rugk/unicodify/pull/72/commits/a8b95bbea3b6030dd620d290e070900eff9ca67c, which is part of #72. I am not sure if I can tag commits in a PR, but the actual commit was the latest in #72 (https://github.com/rugk/unicodify/pull/72/commits/8917637a3431535c604ca10e802478b847a5970d).

rugk commented 2 years ago

I am not sure if I can tag commits in a PR,

Git tags are always possible, but yeah they may only be visible in your fork and not mine. Anyway. nevermind. Next time.