rugk / unicodify

✍️ A browser add-on (Firefox, Chrome, Thunderbird) that allows you to autocorrect common text sequences and convert text characters to a look like a special font.
https://addons.mozilla.org/firefox/addon/unicodify-text-transformer/?utm_source=github.com&utm_medium=git&utm_content=repo-about-description&utm_campaign=github
Other
11 stars 2 forks source link

Added notifications on install/update and exit survey on uninstall #80

Closed tdulcet closed 1 year ago

tdulcet commented 1 year ago

image image

Per our discussion in https://github.com/TinyWebEx/RandomTips/issues/9, the Notifications.js module will need to be refactored to support clicking on the notifications. For now I added this functionality to the new InstallUpgrade.js module (adapted from the Awesome Emoji Picker) to show the necessarily changes.

TODO:

I believe this along with #72 should finally allow us release v1.0.

rugk commented 1 year ago

Once you approve it, I can move it to https://cryptpad.fr/form/ as requested.

AFAIK you can do the same "work together workflow" or so there, too, so you can just invite me by mail or link or whatever. Then one can just adjust it online as needed.

But good idea in general, as said.

tdulcet commented 1 year ago

AFAIK you can do the same "work together workflow" or so there, too, so you can just invite me by mail or link or whatever. Then one can just adjust it online as needed.

OK, I have never used https://cryptpad.fr/form/, so that is good to know. I will look into moving the exit survey there... In the meantime, I sent you an invitation to the draft on Google Forms.

tdulcet commented 1 year ago

BTW that autocorrect refactoring should have been a new PR, so…

Yes, sorry, I wrote this code a couple of months ago and I was going to create a new PR after this one was merged. However, I decided to push it here before I forgot since this PR was still waiting for your review and the changes do not add any functionality...

I tried to think my way around it, but still don't see how/why that generates a more optimized RegEx.

I hope my above comments explained it, but I am happy to answer any additional questions.

tdulcet commented 1 year ago

As requested, I moved the draft exit survey to CryptPad: https://cryptpad.fr/form/#/2/form/view/TyXGnnNjCOo+iC2qrvPzfO8NMK4jMg3pRKxL0mrYNs8/. I will send you an e-mail with the link to edit it.