rugwizangoga / Kanban-board

MIT License
0 stars 0 forks source link

Peer to peer code review week 5 module 2 #21

Open Kashif-Saleem-Ghuman opened 1 year ago

Kashif-Saleem-Ghuman commented 1 year ago

Hi Team,

You did extremely great on this task! 👏 👏 There are however a few issues that you still need to work on, but you are almost there! 🏎️ 🏎️

Highlights 👍 Nice job for providing a succinct description of the cards ❕ Required Changes ♻️ Kindly note that the total number of cards for a team of two should be equal to 15. Created cards appear not assigned! Kindly ensure that all cards are assigned to team members. [Hint: doing so, you should see a circle with the user's avatar on each card. See the example below]: image Cheers!👏 💻 🍷

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

DammyShittu commented 1 year ago

Hi @rugwizangoga,

Highlights

✔️ Descriptive PR

Great work on making the changes requested by a previous reviewer 👏 You've done well implementing some of the requested changes, but there are still some which aren't been addressed yet.

Required Changes ♻️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.