search

ruhley / angular-color-picker

Vanilla AngularJS Color Picker Directive with no requirement on jQuery
http://ruhley.github.io/angular-color-picker/
MIT License
165 stars 78 forks source link

3.4.2 bug Cannot read property 'updateOn' of undefined #167

Closed stephennancekivell closed 7 years ago

stephennancekivell commented 7 years ago

Hi mate, somethings not right with this latest release. I get this error. The tests seem to pass though. (congrats for getting travis to work! 🤠)

I think you need ngModelOptions defined in the directive isolation scope. Also it would be nice if it were optional.

Cannot read property 'updateOn' of undefined
    at new NgModelOptionsController (gallery.js:95745)

So I dont have much time to look at this at the moment.

ruhley commented 7 years ago

@stephennancekivell I definitely tested without passing in ng-model-options and cannot replicate the problem. I may need more to go on to try and fix it.

stephennancekivell commented 7 years ago

Hi, yea thanks. It looks like its only on angular 1.5.

ruhley commented 7 years ago

Fixed in commit 61469d5545074ff3695e0966aad7e932ed5d6546 and released in v3.4.3

stephennancekivell commented 7 years ago

Legend! Thanks mate, I owe you a beer.