ruhley / angular-color-picker

Vanilla AngularJS Color Picker Directive with no requirement on jQuery
http://ruhley.github.io/angular-color-picker/
MIT License
165 stars 78 forks source link

Two-way binging is half-broken since version 3.4.2 #184

Open fifonik opened 6 years ago

fifonik commented 6 years ago

Thanks for the nice color picker.

After upgrading to version 3.4.8 two-way binding is not working as expected. I played a bit and found that some changes in version 3.4.2 caused this.

How to re-produce:

  1. Create a simple inline color picker using version 3.4.1
  2. Try to choose color with mouse -- you'll see that color values in input and in two-way binging var are changing
  3. Double click the color code in input to select it and key in 000. You'll see that the color in color picker changed and two-way binding in updated
  4. Repeat the same steps with version 3.4.2+. Step 3 will fail: when you keying in the color 000 in the input field, two-way binding will not be updated any longer.

Demos: 3.4.1: http://plnkr.co/edit/Oq6OYgtUtYOW7omfuvIv

3.4.8: http://plnkr.co/edit/x1YLyRGxQfivXddDoONc