search

ruhley / angular-color-picker

Vanilla AngularJS Color Picker Directive with no requirement on jQuery
http://ruhley.github.io/angular-color-picker/
MIT License
165 stars 78 forks source link

onchange event is not firing after drag&drop #48

Closed VladaStechr closed 8 years ago

VladaStechr commented 8 years ago

Hi Ruhley, when you select color via drag&drop, event is fired. But after that when you just click to select color, it is not. I think, that problem is in first if statement in mouseUp function. Bye, Vlada

ruhley commented 8 years ago

I can confirm that the first click after drag does not fire the on change function.

Thanks for the pick up :+1:

ruhley commented 8 years ago

It was actually the order of the mouse events. The click was triggered after onChange, so it actually sent the previous value for click events. This also caused the problem of no onChange of the first click after a drag.

Fixed in commit a58a5d5ed00c1fb6cc0c3e42b9bbca863e36df15 and released in v0.8.1