search

ruhley / angular-color-picker

Vanilla AngularJS Color Picker Directive with no requirement on jQuery
http://ruhley.github.io/angular-color-picker/
MIT License
165 stars 78 forks source link

Initial value is partially set #81

Closed jozsi closed 8 years ago

jozsi commented 8 years ago

Hello,

This should describe the problem: image

I have a value set in the model, but until the first user interaction it doesn't properly position the color-picker-picker on the color-picker-grid, respectively the color-picker-slider on the color-picker-hue.

c00lankit commented 8 years ago

jozsi can u give me color picker code.... Ankit.rajpoot93.ar@gmail.com

ruhley commented 8 years ago

Fixed in commit 11b3d428c5081b4e3ba9a1aecf95038841d291ae and released in v1.1.5

jozsi commented 8 years ago

@ruhley: thanks, but it only partially fixes the problem. image

As you can see, the slider doesn't seem to work.

ruhley commented 8 years ago

@jozsi Are you able to create a jsfiddle or plunkr to replicate this problem as it works for me. Also which browser are you using?

jozsi commented 8 years ago

I've created a Plunkr that replicates the problem. I'm using Chrome.

ruhley commented 8 years ago

Fixed in commit 004b66e3f27b7e2776e17679638e93bf5affe3a6 and released in v1.1.6

jozsi commented 8 years ago

It works as expected now, thank you!

jozsi commented 8 years ago

I found yet another case with wrong initials values, however, I didn't have time to create a plunker: image

jozsi commented 8 years ago

Updated the Plunkr - it happens when inline is true and the value is set directly, not via $timeout.

ruhley commented 8 years ago

Fixed in commit 5622dc6a15becde7ba362aa1c5df1d525968e05b and released in v1.1.7

jozsi commented 8 years ago

Looks good. Has a small flicker (it starts in a position then jumps to the correct position), but that might be caused by my app. Thanks!