ruhoh / ruhoh.rb

http://ruhoh.com
616 stars 69 forks source link

generate RSS using RFC-822 compliant dates #297

Closed Stantheman closed 10 years ago

Stantheman commented 10 years ago

The RSS spec requires feeds to specify dates using the RFC-822 spec. The user can specify their own time format for display in config.yml, but RSS date formats can't be custom without making the feed invalid.

W3C has a great validator: http://validator.w3.org/feed/

I found this because my own little RSS reader got upset trying to read a feed created from a Ruhoh blog. Most big readers have relaxed parsing, but as long as doing it right is easy, I think we should :smile:

I installed ruhoh and threw together a basic site, confirmed the default behavior and checked against W3C for failure, made these changes, and validated my feed afterward, and it looks like the cucumber tests pass too. Please let me know if there's something else that would be good to have in this change!

plusjade commented 10 years ago

Looks like a winner to me! Thanks for taking the time to lookup the spec and run the tests! :smiley:

Stantheman commented 10 years ago

No problem :smile: Thank you for being so quick to review!

plusjade commented 10 years ago

Coincidently, after a long, long, quiet period in ruhoh, I am just today starting to work on finishing 3.0! I realize that I use ruhoh for prototyping landing page sites 95% of the time. So I'm determined to finish 3.0. under the assumption that all people really need is a 1-1 file to url site with added modern tooling like asset-pipeline, fingerprinting, markdown, rss, etc.

So I am now re-inspired -- let's hope it lasts!