Challenge 1 Feedback - Githubissues

ruhsane / CS2.2-Graphs-Challenges

0 stars 0 forks source link

Challenge 1 Feedback #1

Open meredithcat opened 5 years ago

meredithcat commented 5 years ago

Challenge 1 Feedback: 4/20 Feedback based on Challenge 1 Rubric

Solution: 1 (x2 = 2)
- Does not handle unweighted graphs
- All graphs are treated as directed graphs
Documentation: 1
- Add docstrings to all methods, including file parsing methods, describing their purpose and input/output
Organization: 2
- Put file parsing logic into its own function(s) with clear responsibilities
Testing: 0
- Add unit tests

ruhsane commented 5 years ago

Hey Meredith, Thanks for the feedback, I've now implemented it to handle weighted/unweighted, directed/undirected graphs, added tests and documentation.

meredithcat commented 5 years ago

Challenge 1 Feedback (Regrade): 13/20

Solution: 3 (x2 = 6)
- Handles weighted/unweighted, directed/undirected
Documentation: 2
- Comments look good. However some docstrings are not consistent in format.
Organization: 3
- Classes & functions look good!
Testing: 2
- Most tests are only testing that the graph contains the correct number of vertices/edges; not actually checking the graph content.
- No tests of make_graph_from_file function.