search

rui-cruz / Spark-Material

Flex spark based components and skins with Material design by google
Other
26 stars 7 forks source link

Clean-up the repo #27

Open olafkrueger opened 8 years ago

olafkrueger commented 8 years ago

Hi Rui, I've started to clean-up the repo and cherry-picked the FloatingActionButton from dev to master. Would be great if we also could merge the textarea to master.

Thanks, Olaf

rui-cruz commented 7 years ago

Hi Olaf,

I'm using the TextArea on a released app, but I did not tested all the issues involving using scrollbar or not.. I think we could make a better approach on that.. instead of using two skins. I'll take a look on that later.

olafkrueger commented 7 years ago

Hi Rui, yes, the two skin approach was just a first try. I thought we have fixed this already and replace it by just one skin? But I also remember some scroll bar issues... Olaf

olafkrueger commented 7 years ago

Ok, I've finally tested your TextArea branch and as you've already pointed out in your commit the issue that is left is that setting "maxHeigth" of the parent container doesn't work properly and the viewport/scroller is not activated if the TextAreas "size" will be bigger than "maxHeight".

Maybe the option to set the TextAreas "height" itself will work for most use cases... What do you think of cherry picking the TextArea to master and if the donation becomes true we could file a JIRA for this issue.

Olaf