rui314 / setup-mold

A GitHub Action to install the mold linker
MIT License
115 stars 10 forks source link

check if a symbolic link already exists #5

Closed garasubo closed 2 years ago

garasubo commented 2 years ago

Fix #4

Add check before creating symbolic link to prevent ln command failure

rui314 commented 2 years ago

I'm not a self hosted runner user so I don't know if it is reasonable to destructively overwrite a system command using a GitHub actions. It is ultimately a users responsibility to installing GitHub actions, but is it commonly expected?

garasubo commented 2 years ago

I think in most case, a self hosted runner is built on independent environment, like VM, AWS instances, and things like that. So, sometimes, it needs to overwrite a system command using a GitHub Action

rui314 commented 2 years ago

OK, if a user want to use this Action, it's ultimately their responsibility to use it correctly.