ruiaylin / goprotobuf

Automatically exported from code.google.com/p/goprotobuf
Other
0 stars 0 forks source link

Go1 tag? #28

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Can we have a go1 tag of a stable hash for go get?  That way running go get 
won't get the tip every time and potentially cause issues

Original issue reported on code.google.com by manoj.da...@moovweb.com on 5 Jul 2012 at 10:56

GoogleCodeExporter commented 9 years ago
The tip of goprotobuf is always meant to be compatible with Go 1, so there's no 
need for a go1 tag.

Original comment by dsymo...@golang.org on 5 Jul 2012 at 11:33

GoogleCodeExporter commented 9 years ago
I understand that the tip is compatible with go1, but my concern is that the 
tip is just an unstable build for the go get tools to use as default.

For example, we've been using go get http://code.google.com/p/goprotobuf/proto 
for our code, but recently a bunch of helper functions were removed dealing 
with pointers (GetString, GetInt32, etc...).  This caused compile time issues 
for the rest of our code that used those functions.

Likewise, not too long ago a new interface was introduced which required us to 
regenerate our proto files.

I totally get that these are changes that we'll have to do eventually, but it 
would be nice to do them all in one go when the tip gets promoted to go1 at a 
stable pace as opposed to having to deal with every minor change pushed to the 
tip.

Well, that's my two cents anyways.

Original comment by manoj.da...@moovweb.com on 5 Jul 2012 at 11:49

GoogleCodeExporter commented 9 years ago
Sure. I understand your concerns. The changes we make are not done
lightly, and they are done fairly infrequently. I'm not sure promoting
them with a go1 tag at some point later would help all that much; in
your situation you would still get an abrupt breakage when we
eventually moved the tag.

Original comment by dsymo...@golang.org on 5 Jul 2012 at 11:51

GoogleCodeExporter commented 9 years ago
I suppose that's fair.  I guess I am just concerned about the frequency of 
local breakages as opposed to the fact that there will be some.  But I 
understand that given the frequency of updates, it might not be worth while 
batching them to a go1 promotion.

Original comment by manoj.da...@moovweb.com on 6 Jul 2012 at 1:01