search

ruifm / gitlinker.nvim

A lua neovim plugin to generate shareable file permalinks (with line ranges) for several git web frontend hosts. Inspired by tpope/vim-fugitive's :GBrowse
GNU General Public License v3.0
535 stars 45 forks source link

Encode Spaces #104

Open joshmedeski opened 8 months ago

joshmedeski commented 8 months ago

Describe the bug I was trying to create a link that has a space in the URL

I expected all characters to be encoded into a valid URL

https://github.com/joshmedeski/dotfiles/blob/7a2f275e57d4a5e53da733bccfd8b2bca1928627/Library/Application%20Support/lazygit/config.yml#L85

The space was not encoded and created an invalid URL (See "Application Support" in URL below)

https://github.com/joshmedeski/dotfiles/blob/7a2f275e57d4a5e53da733bccfd8b2bca1928627/Library/Application Support/lazygit/config.yml#L85

To Reproduce

Generate a link that points to a directory that includes a space.

Expected behavior Encode the URL values before copying it to the clipboard.

System (please complete the following information):

linrongbin16 commented 8 months ago

hi @joshmedeski , let's discuss this issue at: https://github.com/linrongbin16/gitlinker.nvim/issues/224.

Also see: https://github.com/ruifm/gitlinker.nvim/issues/91