search

ruihan00 / pe

0 stars 0 forks source link

Inaccuracy in DG diagram #12

Open ruihan00 opened 2 years ago

ruihan00 commented 2 years ago

The part mentions that person and modules share a similar field which is ModuleCode. the arrow from person and module points to a singular module code field

However this does that seem as the case as a person can be associated to a module code that is non existent in nus or in the application

Screenshot 2022-11-11 at 5.29.54 PM.png

nus-se-script commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Same issue as #2742

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Possible error in Model component diagram

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Through the testing of the app, I was able to add multiple ModuleCode for each Person. However, this, with the fact that Module should reference only 1 ModuleCode is not indicated in the model diagram.

Screen Shot 2022-11-11 at 5.30.12 PM.png

[original: nus-cs2103-AY2223S1/pe-interim#2329] [original labels: severity.VeryLow type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Multiplicity is optional in a class diagram. The class diagram module code for person and module may not be the same.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]