search

ruihan00 / pe

0 stars 0 forks source link

No exception thrown for a email that violates restrictions #7

Open ruihan00 opened 2 years ago

ruihan00 commented 2 years ago

The email restrictions that are stated in the user guide is that the domain portion consist of 2 domain labels separated by a .

However when attempting a command that violates this restriction by adding email nus@nus which is the domain portion should consist of 2 domain labels, the email is successfully added (refer to second screenshot)

This should be a bug as there is no exception caught for this restriction but there is exception thrown for the rest of the restrictions in the diff fields (phone/name)

Screenshot 2022-11-11 at 5.02.16 PM.png

Screenshot 2022-11-11 at 5.01.09 PM.png

nus-se-script commented 2 years ago

Team's Response

Flaw is unlikely to affect normal operations of the product as users will only want to record valid email addresses.

This group of bugs can be fixed by fixing the regex checked for emails

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: Application should alert users to possible invalid emails as it can be a typo and would hinder user usage when attempting to use this info later on