search

ruijietay / pe

0 stars 0 forks source link

Phone numbers and emails can be non-unique #5

Open ruijietay opened 2 months ago

ruijietay commented 2 months ago

As stated in the UG, phone numbers and email must be unique. However, this is not the case in the application, since I can add multiple students with same numbers and emails (with different names). This applies to the edit command.

image.png

nus-se-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

TutorPro allows duplicate persons with same name and email

Outline The UG states that TutorPro does not allow duplicate persons. They can have the same name but phone and email must be unique.

Evidence in UG Screenshot 2024-04-19 at 4.47.27 PM.png

What actually happens? It seems that TutorPro actually does not allow people of same names, but allows people of same phone and email. Please see the evidence below.

Why Medium Severity If users don't figure this out themselves, they might not be able to enter any users as TutorPro will block the command actions. The UG and app behaviour are different.

Same name different phone and email: Screenshot See index 9 and my command input.

Screenshot 2024-04-19 at 4.50.52 PM.png

Different name but same phone and email: Screenshot See index 11 and 12.

Screenshot 2024-04-19 at 4.49.57 PM.png

[original: nus-cs2103-AY2324S2/pe-interim#5216] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

This is actually a documentation bug as it is intended for students to be able to have the same phone number and email. This is because especially for younger students, their point-of-contact might be their parents, and if they have the same point-of-contact, they will have the same phone number and email.

Hence this part is a low severity documentation bug.

For the name part, it is a functionality bug. However, this will not cause a huge inconvenience to the user as they can just add numbering if they happen to have students/parents with the same names, e.g. if there are 3 Jane Does (which is already highly unlikely), they can just save their contact names as Jane Doe 1, Jane Doe 2, and Jane Doe 3.

Hence, this bug with the names is not as important as the work already done in v1.4. Hence, it is a low severity documentation bug.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue type Team chose [`type.DocumentationBug`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]