search

ruijietay / pe

0 stars 0 forks source link

Error message is inconsistent #7

Open ruijietay opened 2 months ago

ruijietay commented 2 months ago

When entering an index above the valid indices in the list, the error message is The person index provided is invalid. However, when entering 0, or a negative index, more information is provided: Invalid command format! delete: Deletes the person identified by the index number used in the displayed contact list. Parameters: INDEX (must be a positive integer) Example: delete 1

image.png

image.png

soc-se-bot commented 2 months ago

Team's Response

This issue is not as important as the work already done in v1.4. This is because in the error message for delete 0 and delete NEGATIVE_NUMBER, the users are informed that the index must be a positive integer. For the error message for when an index is larger than the list size, it is quite self-explanatory why the index is invalid, as the list is numbered and the user can easily see how many contacts they actually have. Therefore, this does not inconvenience users.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Referencing the CS2103 website here, it states that:

image.png

Specifically, The feature can be implemented in a better way without much additional effort. Ensuring that error messages follow a similar format that provides more information to the user (i.e. the first screenshot in the original bug report) is just a matter of following an error message format that should be agreed on by the team, and should be done easily if proper principles like abstraction and DRY is followed.