search

ruijietay / pe

0 stars 0 forks source link

event command allows for negative hours #8

Open ruijietay opened 2 months ago

ruijietay commented 2 months ago

Entering event n/Bob math tutoring at/2024-03-04 12:60 h/-1 t/math t/tutoring is allowed

nus-pe-script commented 2 months ago

Team's Response

Users can easily and conveniently prevent this issue by not entering negative hours. Hence, this issue is not as important as the work already done in v1.4.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Referencing the CS2103 website here, we can see that this bug does not fulfil either of the two points:

image.png

Specifically,

  1. The UG did not specify anything related to the input of negative hours.
  2. The user is still allowed to input negative hours and does not fail gracefully when done.

In addition, these conditions stated in the CS2103 website here states that:

image.png

Specifically, The feature can be implemented in a better way without much additional effort. Ensuring that no negative hours are allowed should only require a simple if statement check, or a simple tweak to the regular expression used to validate the user input.