search

ruimarinho / authy-client

A complete Authy client with support for TOTP, OneTouch, Phone Verification and Phone Intelligence APIs
122 stars 27 forks source link

Logging options override cached `request` object #12

Closed pedrobranco closed 7 years ago

pedrobranco commented 8 years ago

When defining the logging options of request it modifies by reference the require cached object request, making all the system log requests that don't want to.

Problem: Any application that uses request and uses this client will log all the requests, even we do not want to log them. See this.

ruimarinho commented 8 years ago

Indeed, this is an issue with request-debug, which an update will likely require using the return value of that wrapper.

ruimarinho commented 8 years ago

Waiting for https://github.com/request/request-debug/pull/18 to be merged.