Change Phone Verification token type from Number to String.

ruimarinho / authy-client

A complete Authy client with support for TOTP, OneTouch, Phone Verification and Phone Intelligence APIs

122 stars 27 forks source link

Change Phone Verification token type from Number to String. #7

Closed madmod closed 8 years ago

madmod commented 8 years ago

This fixes a bug where a phone verification code starting with a zero is unverifiable. This change will break any existing implementations using this method, however any system without this will be unusable 1/10 times, requiring the user to wait for their current token to expire.

Edit: ~~It looks like this needs some more work. Right now Authy gives me the following response when attempting a code.~~

Edit: The issue was missing tests. I've added them now.

ruimarinho commented 8 years ago

🤔 -- thanks for catching this @madmod. I've landed your PR as https://github.com/seegno/authy-client/commit/d5b66cef774e681a62ea28a053afdc85902244ed with some changes:

Removed dist/ changes as that is left to the release commit.
Renamed PhoneToken to PhoneVerificationToken to avoid ambiguity.
Removed comments regarding token size as I will confirm this via support.

Thanks!