ruimarinho / bitcoin-core

A modern Bitcoin Core REST and RPC client.
480 stars 188 forks source link

Add logging to all requests #19

Closed pedrobranco closed 7 years ago

pedrobranco commented 7 years ago

This PR adds logging to all requests made with bitcoin-core, using as logger the seegno/debugnyan module.

Since there is sensitive data in the following methods calls:

by default we are obfuscating all sensitive data with the string ******.

pedrobranco commented 7 years ago

You mention an obfuscation option in the PR, but the code has none.

I'd rather leave the obfuscating only for the default logger. I'll leave the obfuscation both for default and custom logging.

pedrobranco commented 7 years ago

This PR now depends on #21.