search

ruimarinho / bitcoin-core

A modern Bitcoin Core REST and RPC client.
480 stars 188 forks source link

Fix camelcase consistency for mempool calls #20

Closed johnbailon closed 7 years ago

johnbailon commented 7 years ago

Small fix on camelCase consistency for mempool call.

ruimarinho commented 7 years ago

I see that Travis tests are failing but it's unrelated to your PR (should have used a fixed Docker image). How angry does this inconsistency makes you feel :-)? This would require a major version due to the breaking change..

johnbailon commented 7 years ago

@ruimarinho haha, don't sweat it. I ran into it and thought it should make for a nice pull request. Feel free to wait for other fixes to make the major version bump worth it.

ruimarinho commented 7 years ago

This will likely be merged when the returned numbers are changed to be returned as strings.

ruimarinho commented 7 years ago

@johnbailon I'm more inclined to rename the other methods to Mempool instead of MemPool.

johnbailon commented 7 years ago

@ruimarinho why so? Do note that bitcoind's docs use MemPool.

ruimarinho commented 7 years ago

@johnbailon most people are using mempool or Mempool:

Looks like the only place where MemPool is used is in the bitcoin developer reference docs.

promag commented 7 years ago

The fix should be s/MemPool/Mempool.