search

ruimarinho / bitcoin-core

A modern Bitcoin Core REST and RPC client.
477 stars 186 forks source link

RPC changes on bitcoin core v0.17.0 #77

Closed jeromevonk closed 5 years ago

jeromevonk commented 5 years ago

There are new RPC methods on bitcoin core version 0.17.0.

Will there be support for this new methods?

pedrobranco commented 5 years ago

Will there be support for this new methods?

Yes, but you can help us by submitting a PR for adding support or listing here all the RPC changes 💯

jeromevonk commented 5 years ago

From 0.16.0: rescanblockchain savemempool

From 0.17.0 converttopsbt createpsbt walletcreatefundedpsbt walletprocesspsbt finalizepsbt combinepsbt decodepsbt signrawtransactionwithkey signrawtransactionwithwallet getaddressinfo getaddressesbylabel getreceivedbylabel listlabels listreceivedbylabel setlabel

List of all RPCs on v0.17.0 attached RPC Calls 0.17.0.txt

juscamarena commented 5 years ago

I can add a PR with most of these.

juscamarena commented 5 years ago

Adding these new methods is actually the easiest part.

Doing it the right way is hard as upgrading the docker image to bitcoind 0.17 breaks a lot of tests, this will probably need a major version upgrade.

Should I up the default docker image to use 0.17 and update all the tests targeting this or should I create a new bitcoind 0.17 image and create a separate set of tests for this? @ruimarinho @pedrobranco I'm happy to spend the time doing so as I use this package a lot.

juscamarena commented 5 years ago

I've created a PR that still needs some work here #84

pedrobranco commented 5 years ago

Fixed by #94.