search

ruimarinho / bitcoin-core

A modern Bitcoin Core REST and RPC client.
477 stars 186 forks source link

0.17 methods #84

Closed juscamarena closed 5 years ago

juscamarena commented 5 years ago

I've updated default bitcoind docker image to 0.17 as well as for the multiwallet.

A lot of tests broke with this update, I've fixed many of them and removed some that didn't make sense anymore, this may need some work.

I still need to add 'signrawtransactionwithkey', 'sethdseed' these two commands, possibly a signrawtransaction change (I believe there's an issue for that).

Need to update documentation as well.

pedrobranco commented 5 years ago

Thanks for the pull request @juscamarena.

Can we create an initial commit only with the src/methods which are required for the 0.17 version? Then we can add other commits on top of that for bumping the containers versions and fixing all the tests.

juscamarena commented 5 years ago

Sure thing.

juscamarena commented 5 years ago

I've combined the container update and test commits together, I can separate them out as needed, there are probably some more tests that can be added as well.

juscamarena commented 5 years ago

1 test fails, there are a few missing methods.

One is quite peculiar getaddressbyaccount, I've never seen this one before, rpc method is getaddressesbyaccount not getaddressbyaccount so not sure why tests fails there.

The other PR includes signrawtransactionwithkey so I didn't include it here.

juscamarena commented 5 years ago

Looks like no interest. I'll just start making changes to my own forked version of this.

pedrobranco commented 5 years ago

Looks like no interest. I'll just start making changes to my own forked version of this.

I'm very sorry about the delay but we haven't much time lately. I will pick this right now.

pedrobranco commented 5 years ago

Replaced by #94 which is rebased and fixed a failing test. Thanks @juscamarena.